[meta-xilinx] [PATCH] u-boot-xlnx: provide overrideable repo/branch plumbing

[Nathan Rossi]

On 16 May 2017 at 07:38, Manjukumar Matha
<manjukumar.harthikote-matha at xilinx.com> wrote:
> With these patches, top level component selection configuration can now
> easily override u-boot-xlnx source repositories and branches.

This sounds like it is a hack for PetaLinux?

As I queried with the other patch doing the equivalent for
arm-trusted-firmware. Why do you need this and why can you not achieve
the same with other existing mechanisms, such as:

* Use PREMIRRORS to fetch from internal git repo instead of public
(rewrite git uris)
* EXTERNALSRC -> point at a completely custom source (doesn't even
need to be git)
* Use devtool (does equivalent to EXTERNALSRC) to modify the source
* bbappend and change SRC_URI/SRCREV
* Override {SRC_URI/SRCREV}_pn-arm-trusted-firmware from any conf
* Locally modify the layer/recipe for temporary changes

>
> Signed-off-by: Cyril Chemparathy <cyril.chemparathy at xilinx.com>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha at xilinx.com>
> ---
>  recipes-bsp/u-boot/u-boot-xlnx.inc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-bsp/u-boot/u-boot-xlnx.inc b/recipes-bsp/u-boot/u-boot-xlnx.inc
> index dd28a05..defe17e 100644
> --- a/recipes-bsp/u-boot/u-boot-xlnx.inc
> +++ b/recipes-bsp/u-boot/u-boot-xlnx.inc
> @@ -2,8 +2,11 @@ require recipes-bsp/u-boot/u-boot.inc
>
>  DEPENDS += "dtc-native"
>
> +UBOOTURI ?= "git://github.com/Xilinx/u-boot-xlnx.git;protocol=https"
>  UBRANCH ?= "master"
> -SRC_URI = "git://github.com/Xilinx/u-boot-xlnx.git;protocol=https;branch=${UBRANCH}"
> +
> +UBRANCHARG = "${@['nobranch=1', 'branch=${KBRANCH}'][d.getVar('UBRANCH', True) != '']}"

You add this variable but it is unused?

Also KBRANCH should be UBRANCH, and avoid using "d.getVar(foo, True)"
just use "d.getVar(foo)".

Regards,
Nathan

> +SRC_URI = "${UBOOTURI};branch=${UBRANCH}"
>
>  S = "${WORKDIR}/git"
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
> --
> 2.7.4
>
> --
> _______________________________________________
> meta-xilinx mailing list
> meta-xilinx at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-xilinx