[meta-xilinx] [PATCH] u-boot-xlnx: provide overrideable repo/branch plumbing

[Manjukumar Harthikote Matha]

Hi Nathan,

> -----Original Message-----
> From: Nathan Rossi [mailto:nathan at nathanrossi.com]
> Sent: Wednesday, May 17, 2017 5:49 AM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>
> Cc: meta-xilinx at lists.yoctoproject.org
> Subject: Re: [meta-xilinx] [PATCH] u-boot-xlnx: provide overrideable repo/branch
> plumbing
>
> On 16 May 2017 at 07:38, Manjukumar Matha
> <manjukumar.harthikote-matha at xilinx.com> wrote:
> > With these patches, top level component selection configuration can now
> > easily override u-boot-xlnx source repositories and branches.
>
> This sounds like it is a hack for PetaLinux?
>
This was for CI system which runs on multiple branches and also widely used with multiconfig mechanism.
Each multiconfig can run different feature branch during development.

> As I queried with the other patch doing the equivalent for
> arm-trusted-firmware. Why do you need this and why can you not achieve
> the same with other existing mechanisms, such as:
>
> * Use PREMIRRORS to fetch from internal git repo instead of public
> (rewrite git uris)
> * EXTERNALSRC -> point at a completely custom source (doesn't even
> need to be git)
> * Use devtool (does equivalent to EXTERNALSRC) to modify the source
> * bbappend and change SRC_URI/SRCREV
The above are definitely helpful for developer purpose which is recommended.

Thanks
Manju

> * Override {SRC_URI/SRCREV}_pn-arm-trusted-firmware from any conf
> * Locally modify the layer/recipe for temporary changes
>
> >
> > Signed-off-by: Cyril Chemparathy <cyril.chemparathy at xilinx.com>
> > Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha at xilinx.com>
> > ---
> >  recipes-bsp/u-boot/u-boot-xlnx.inc | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/recipes-bsp/u-boot/u-boot-xlnx.inc b/recipes-bsp/u-boot/u-boot-
> xlnx.inc
> > index dd28a05..defe17e 100644
> > --- a/recipes-bsp/u-boot/u-boot-xlnx.inc
> > +++ b/recipes-bsp/u-boot/u-boot-xlnx.inc
> > @@ -2,8 +2,11 @@ require recipes-bsp/u-boot/u-boot.inc
> >
> >  DEPENDS += "dtc-native"
> >
> > +UBOOTURI ?= "git://github.com/Xilinx/u-boot-xlnx.git;protocol=https"
> >  UBRANCH ?= "master"
> > -SRC_URI = "git://github.com/Xilinx/u-boot-
> xlnx.git;protocol=https;branch=${UBRANCH}"
> > +
> > +UBRANCHARG = "${@['nobranch=1',
> 'branch=${KBRANCH}'][d.getVar('UBRANCH', True) != '']}"
>
> You add this variable but it is unused?
>
> Also KBRANCH should be UBRANCH, and avoid using "d.getVar(foo, True)"
> just use "d.getVar(foo)".
>
> Regards,
> Nathan
>
> > +SRC_URI = "${UBOOTURI};branch=${UBRANCH}"
> >
> >  S = "${WORKDIR}/git"
> >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > meta-xilinx mailing list
> > meta-xilinx at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-xilinx


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.