[meta-xilinx] [PATCH] machine-xilinx-default.inc: Add default tune for multilib lib32 builds

Nathan Rossi nathan at nathanrossi.com
Tue May 30 03:54:11 PDT 2017


On 27 May 2017 at 08:18, Manjukumar Matha
<manjukumar.harthikote-matha at xilinx.com> wrote:
> On ZU+ machines, we set the default tune for the lib32 multilib
> configuration.This allows users to select multilib by simply requiring
> conf/multilib.conf in their build setups.
>
> Signed-off-by: Cyril Chemparathy <cyril.chemparathy at xilinx.com>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha at xilinx.com>
> ---
>  conf/machine/include/machine-xilinx-default.inc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/conf/machine/include/machine-xilinx-default.inc b/conf/machine/include/machine-xilinx-default.inc
> index 24d78bc..7b7a549 100644
> --- a/conf/machine/include/machine-xilinx-default.inc
> +++ b/conf/machine/include/machine-xilinx-default.inc
> @@ -42,3 +42,6 @@ XSERVER ?= " \
>
>  XSERVER_EXT ?= ""
>  XSERVER_EXT_zynqmp ?= "xf86-video-armsoc"
> +
> +# Support multilib on zynqmp
> +DEFAULTTUNE_virtclass-multilib-lib32_zynqmp = "armv7vehf-neon-vfpv4"

I think this would be better set in tune-zynqmp.inc (alongside the
DEFAULTTUNE) as a ?=. That way it is not forced with an override and
can be easily modified since MULTILIB tunes are really distro level
config.

Also since the A53 does T32 instructions you should allow thumb with
the armv7vethf-... variant.

Regards,
Nathan



More information about the meta-xilinx mailing list