[meta-xilinx] [PATCH 5/9] libgloss: Copy libgloss as libxil to avoid linking issues

[Alejandro Enedino Hernandez Samaniego]

Hey Luca,


On 12/11/2018 07:43 AM, Luca Ceresoli wrote:
> Hi Alejandro,
>
> On 06/12/18 22:56, Alejandro Enedino Hernandez Samaniego wrote:
>> Upstream gcc expects to have libxil available when linking, we can get
>> the required symbols (weak) from libgloss.
>>
>> We copy libgloss as libxil to comply with upstream behavior and avoid
>> linking errors.
> I suggest moving or copying this explanation...
>
>> diff --git a/meta-xilinx-standalone/recipes-standalone/newlib/libgloss_3.0.0.bbappend b/meta-xilinx-standalone/recipes-standalone/newlib/libgloss_3.0.0.bbappend
>> new file mode 100644
>> index 0000000..c2af4f9
>> --- /dev/null
>> +++ b/meta-xilinx-standalone/recipes-standalone/newlib/libgloss_3.0.0.bbappend
>> @@ -0,0 +1,4 @@
>> +# We use libgloss as if it was libxil, to avoid linking issues
> ...here, so it is visible close to the code without need to dig in the
> git archives.

I'll have to disagree in this case, the comment in the code should 
likely be simple, and the comment on the commit message should give a 
little more information about the problem, which is what I believe this 
does.

Cheers,
Alejandro
>
>> +do_install_append_zynqmp-pmu(){
>> +  cp ${D}/${libdir}/libgloss.a ${D}/${libdir}/libxil.a
> A symlink should be enough here.
>