[meta-xilinx] [PATCH] Fix pmu-firmware build to include backend code for ZynqMP FPGA configuration

[Luca Ceresoli]

Hi Andreas, Mounika,

[Cc-ing the main committer of lib/sw_apps/zynqmp_pmufw/misc/copy_bsp.sh]

On 05/01/19 00:01, Andreas Galauner wrote:
> Move the appropriate backend code for the ZynqMP FPGA configuration from the
> interface subdirectory of the xilfpga library into the src directory so that
> the files are picked up by the Makefile. Otherwise the FPGA configuration code
> is non-functional.
> 
> Signed-off-by: Andreas Galauner <andreas at galauner.de>
> ---
>  .../recipes-standalone/pmu-firmware/pmu-firmware_2018.3.bb     | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-xilinx-standalone/recipes-standalone/pmu-firmware/pmu-firmware_2018.3.bb b/meta-xilinx-standalone/recipes-standalone/pmu-firmware/pmu-firmware_2018.3.bb
> index 847e071..3432c1f 100644
> --- a/meta-xilinx-standalone/recipes-standalone/pmu-firmware/pmu-firmware_2018.3.bb
> +++ b/meta-xilinx-standalone/recipes-standalone/pmu-firmware/pmu-firmware_2018.3.bb
> @@ -23,6 +23,9 @@ do_configure() {
>      # manually do the copy_bsp step first, so as to be able to fix up use of
>      # mb-* commands
>      ${S}/../misc/copy_bsp.sh
> +
> +    # fix xilfpga to include the zynqmp backend
> +    mv ${S}/../misc/zynqmp_pmufw_bsp/psu_pmu_0/libsrc/xilfpga/src/interface/zynqmp/* ${S}/../misc/zynqmp_pmufw_bsp/psu_pmu_0/libsrc/xilfpga/src

I confirm the problem exists and your patch solves it. Thanks for sharing.

Considering this as a temporary, urgent fix:
Reviewed-by: Luca Ceresoli <luca at lucaceresoli.net>
Tested-by: Luca Ceresoli <luca at lucaceresoli.net>

However in the long term copy_bsp.h should be fixed to copy the files in
the proper place IMO.

It would be even better if no file were ever copied around, but just
used where it is. When copying files, the files that are actually built
are unversioned copies of the git-versioned files, so:
 * if you run copy_bsp.sh, all changes to the working files are lost!
 * git grep finds files that are not really unused
 * if the working files are edited git diff won't show the differences
 * it's confusing for both programmers and programs like ctags and grep

Mounika, do you think the file copy could be removed? Or at least fixed?

Thanks,
-- 
Luca