[meta-xilinx] [PATCH] libmali-xlnx: inherit update-alternatives only on rw-rootfs builds

[Mike Looijmans]

This should not work, IMAGE_FEATURES is only valid in the image recipe and 
won't be (fully) visible outside that.

I frequently build multiple images in a single bitbake run where one is 
read-only and the other is not, e.g.: "bitbake my-image-sdcard my-image-norflash"


On 16-07-19 03:44, Jean-Francois Dagenais wrote:
> update-alternatives.bbclass adds a target-ran post-inst step which
> cannot work on RO rootfs systems. Thankfully an error was put in place
> in poky's base image class to detect this.
> 
> With this patch, on these builds, the default lib (MALI_BACKEND_DEFAULT)
> prevails as the active library. Others may be used through other tricks
> if they are installed by the do_install step.
> 
> This is obviously not a perfect solution, but at least do_rootfs is
> allowed to complete. Furthermore, on embedded systems, this should cover
> most cases since arguably few of us bundle the multiple implementations
> of libmali on a given machine.
> 
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais at gmail.com>
> ---
>   meta-xilinx-bsp/recipes-graphics/libgles/libmali-xlnx.bb | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-xilinx-bsp/recipes-graphics/libgles/libmali-xlnx.bb b/meta-xilinx-bsp/recipes-graphics/libgles/libmali-xlnx.bb
> index b37e061..af873e6 100644
> --- a/meta-xilinx-bsp/recipes-graphics/libgles/libmali-xlnx.bb
> +++ b/meta-xilinx-bsp/recipes-graphics/libgles/libmali-xlnx.bb
> @@ -4,7 +4,8 @@ LICENSE = "Proprietary"
>   LICENSE_FLAGS = "xilinx"
>   LIC_FILES_CHKSUM = "file://README.md;md5=d5750ae6496dd931669b454b5aaae2cd"
>   
> -inherit distro_features_check update-alternatives
> +inherit distro_features_check
> +INHERIT += '${@bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs", "", "update-alternatives", d)}'
>   
>   ANY_OF_DISTRO_FEATURES = "x11 fbdev wayland"
>   
>