[poky] [PULL]Fix adding GDBM_File module for perl

[Saul Wold]

On 11/01/2010 10:22 AM, Lu Jingdong wrote:
> Note:<commit_id>  parameter assumed as 'HEAD'
>
>    meta/recipes-devtools/perl/perl-5.8.8/config.sh                                     |    8
>    meta/recipes-devtools/perl/perl-5.8.8/perl-enable-gdbm.patch                        |   17 +
>    meta/recipes-devtools/perl/perl_5.8.8.bb                                            |    2
>
This patch looks OK to me and I will pull it.
(Nitin, please take note of this config change for your work).

>    meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.12-zlib.patch                 |  169 ++++++++++
>    meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-data_types.patch          |   32 +
>    meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-help-index-segfault.patch |   23 +
>    meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-mosdo-crash.patch         |   11
>    meta/recipes-extended/texinfo/texinfo-4.13a/texinfo-4.13a-powerpc.patch             |   12
>    meta/recipes-extended/texinfo/texinfo_4.13a.bb                                      |   57 +++

I am just reviewing the textinfo patch at this point and first comment 
is that you need to comment the patches, there is no information about 
their origin and why they are needed.

As we are adding a new recipe, is this based on the existing 
OpenEmbedded recipe and if so, you need to credit OE.  I noticed in OE 
that they have a different set of depends and patches, so I wanted to 
verify this.

Minor nit: for SRC_URI, you could use ${PN} as follows:
    http://ftp.gnu.org/gnu/${PN}/${PN}-${PV}.tar.gz

Sau!




>    9 files changed, 327 insertions(+), 4 deletions(-)
>
> Jingdong Lu (2):
>         texinfo: Add new package
>         Fix adding GDBM_File module for LSB test.
>
> Pull URL:
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro
>