[poky] Inconsistent timestamp use
Saul Wold
saul.wold at intel.com
Wed Nov 3 15:34:40 PDT 2010
On 11/03/2010 08:45 AM, Gary Thomas wrote:
> On 11/03/2010 09:35 AM, Saul Wold wrote:
>> On 11/03/2010 06:58 AM, Gary Thomas wrote:
>>> The Poky root file system (init scripts) has a mechanism for
>>> supporting systems without a working hardware [time of day] clock.
>>> It seems that this has suffered some rot recently and is now
>>> quite inconsistent:
>>> * rootfs_update_timestamp() uses a different format for the time stamp
>>> * the init scripts look for /etc/timestamp2, not /etc/timestamp which
>>> is created with the image
>>>
>>> The attached patch makes this consistent and the system clock now works
>>> much better (about as good as a machine without a hardware clock can!)
>>>
>>
>> Hi Gary,
>>
>> This is a good change for the smaller images that use the busybox date
>> function, but will break images that use the real date command.
>> Unfortunately, they happen to use different formats for setting the time
>> and date.
>>
>> It may be that we need 2 timestamp files, one for a busybox system and a
>> second for the standard date command and then extend the check in the
>> init scripts to figure out which date we are using currently.
>
> Fair enough. I was just trying to make what's there work consistently.
>
> Perhaps it's good enough to remove the "-s" option from the setting
> function and change back to the old format (+%m%d%H%M%Y). I'm pretty
> sure that the full-on date program will handle that, as does busybox.
>
I just verified that the +%2m%2d%2H%2M%Y format will work correctly for
both version of dates, and you are correct that the -s option should go
away.
The save-rtc.sh script needs to be fixed to use the correct format.
I reponed bug #265 and commented that, if you want to add yourself to
that bug.
Sau!
> Note: I think the change 41d02d40ed83c791e7a4c1d57d829d706af42e74 was
> actually incorrect. The proper change would have been to fix the
> timestamp generation to be consistent.
>
More information about the poky
mailing list