[poky] timestamp overkill?

[Gary Thomas]

On 11/10/2010 06:44 AM, Richard Purdie wrote:
> On Thu, 2010-11-04 at 05:44 -0600, Gary Thomas wrote:
>> I just noticed that there are two identical functions in image.bbclass
>> to set/update the image timestamp.  Why?  Left over from a previous era?
>>
>> $ find meta* -name "*.bb*" -or -name "*.inc" | xargs grep create_etc_timestamp
>> meta/classes/image.bbclass:create_etc_timestamp() {
>> meta/classes/image.bbclass:# export the zap_root_password, create_etc_timestamp and remote_init_link
>> meta/classes/image.bbclass:EXPORT_FUNCTIONS zap_root_password create_etc_timestamp remove_init_link do_rootfs make_zimage_symlink_relative set_image_autologin
>> rootfs_update_timestamp rootfs_no_x_startup
>>
>> Notice that 'create_etc_timestamp' does not seem to be used by
>> any recipe.  Perhaps it should be removed?
>
> The one that is unused should probably be removed. Please file a bug
> and/or submit a patch!

Attached.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Remove-superfluous-create_etc_timestamp-function.patch
URL: <http://lists.yoctoproject.org/pipermail/poky/attachments/20101110/96461922/attachment.ksh>