[poky] [PATCH 1/1] *.bbappend: don't expand FILESEXTRAPATHS immediately

[Tian, Kevin]

Please hold on taking this patch.

Josh mentioned to me that below change is risky given below comment in base.bbclass:

# THISDIR only works properly with imediate expansion as it has to run
# in the context of the location its used (:=)
THISDIR = "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"

The comment seems controversial to the actual assignment. When trying to understand
the trick behind, I decide using a simple alternative by including FILESEXTRAPATHS in
BB_BASEHASH_WHITELIST directly

An updated pull request will be sent out soon.

Thanks
Kevin

>From: Tian, Kevin
>Sent: Wednesday, November 24, 2010 12:27 PM
>
>There's no point to expand FILESEXTRAPATHS immediately, since the place where
>it's referenced still use normal getVar(FILESEXTRAPATHS, d, True). This way
>it doesn't help anything except adding one more breaking variable on sstate.
>
>Signed-off-by: Kevin Tian <kevin.tian at intel.com>
>---
> documentation/bsp-guide/bsp.xml                    |    2 +-
> .../recipes/formfactor/formfactor_0.0.bbappend     |    2 +-
> .../recipes/linux/linux-yocto_git.bbappend         |    2 +-
> meta-emenlow/recipes/linux/linux_2.6.33.2.bbappend |    2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/documentation/bsp-guide/bsp.xml b/documentation/bsp-guide/bsp.xml
>index 9e25068..0d716a3 100644
>--- a/documentation/bsp-guide/bsp.xml
>+++ b/documentation/bsp-guide/bsp.xml
>@@ -307,7 +307,7 @@ meta-bsp/packages/image-creator/image-creator-native_0.1.bb
>                 The example below shows extra files contained in a folder called ${PN} (the
>package name).
>             </para>
>             <programlisting>
>-FILESEXTRAPATHS := "${THISDIR}/${PN}"
>+FILESEXTRAPATHS = "${THISDIR}/${PN}"
>             </programlisting>
>             <para>
>             This technique allows the BSP to add machine-specific configuration files to the
>layer directory,
>diff --git a/meta-emenlow/recipes/formfactor/formfactor_0.0.bbappend
>b/meta-emenlow/recipes/formfactor/formfactor_0.0.bbappend
>index 4a41d48..a64f367 100644
>--- a/meta-emenlow/recipes/formfactor/formfactor_0.0.bbappend
>+++ b/meta-emenlow/recipes/formfactor/formfactor_0.0.bbappend
>@@ -1,3 +1,3 @@
>-FILESEXTRAPATHS := "${THISDIR}/${PN}"
>+FILESEXTRAPATHS = "${THISDIR}/${PN}"
>
> PRINC = "1"
>diff --git a/meta-emenlow/recipes/linux/linux-yocto_git.bbappend
>b/meta-emenlow/recipes/linux/linux-yocto_git.bbappend
>index 9fa2937..77c5223 100644
>--- a/meta-emenlow/recipes/linux/linux-yocto_git.bbappend
>+++ b/meta-emenlow/recipes/linux/linux-yocto_git.bbappend
>@@ -1,3 +1,3 @@
>-FILESEXTRAPATHS := "${THISDIR}/${PN}"
>+FILESEXTRAPATHS = "${THISDIR}/${PN}"
> COMPATIBLE_MACHINE_emenlow = "emenlow"
> KMACHINE_emenlow  = "emenlow"
>diff --git a/meta-emenlow/recipes/linux/linux_2.6.33.2.bbappend
>b/meta-emenlow/recipes/linux/linux_2.6.33.2.bbappend
>index fac0921..c6f81d4 100644
>--- a/meta-emenlow/recipes/linux/linux_2.6.33.2.bbappend
>+++ b/meta-emenlow/recipes/linux/linux_2.6.33.2.bbappend
>@@ -1,3 +1,3 @@
>-FILESPATH := "${FILESPATH}:${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
>+FILESEXTRAPATH = "${THISDIR}/${PN}"
> SRC_URI += "file://defconfig"
> COMPATIBLE_MACHINE_emenlow = "emenlow"
>--
>1.6.0.4