[poky] [PATCH 1/1] curl: fix native dependency

Richard Purdie rpurdie at linux.intel.com
Mon Nov 29 03:57:26 PST 2010


On Mon, 2010-11-29 at 16:17 +0800, Qing He wrote:
> On Sun, 2010-11-28 at 22:22 +0800, Richard Purdie wrote:
> > On Wed, 2010-11-17 at 16:26 +0800, Qing He wrote:
> > > @@ -25,6 +24,10 @@ EXTRA_OECONF = "--with-zlib=${STAGING_LIBDIR}/../ \
> > >  		--enable-crypto-auth \
> > >  		"
> > >  
> > > +EXTRA_OECONF_append = " --with-gnutls=${STAGING_LIBDIR}/../"
> > > +EXTRA_OECONF_virtclass-native_append = " --without-gnutls"
> > > +EXTRA_OECONF_virtclass-nativesdk_append = " --without-gnutls"
> > > +
> > >  do_configure_prepend() {
> > >  	sed -i s:OPT_GNUTLS/bin:OPT_GNUTLS:g configure.ac
> > >  }
> > 
> > I'm going to push a fix but I wanted to note that the above is not
> > correct. Let me walk through this since I expect various people find
> > this confusing.
> 
> Thanks for the explanation.
> 
> In fact, at first, I also tried to use
> EXTRA_OECONF_append_virtclass-native, in the hope to override variable
> EXTRA_OECONF_append for different virtual classes. However, the
> log.do_configure still showed "--with-gnutls=...", that's why I then
> changed to the form in the patch, and it looked working.
> 
> 
> And I also see something in the smart data implementation:
>     __setvar_regexp__ = re.compile('(?P<base>.*?)(?P<keyword>_append|_prepend)(_(?P<add>.*))?')
> 
> Does that mean append/prepend is expected to appear before everything
> else?

It means append and prepend only work if they're the last part of the
variable name.

e.g. XXX_append = "YYY"

so XXX_append_ZZZ = "YYY" won't do anything

of course if ZZZ is an override, it will be peeled off but the append
only happens after its been overridden and it becomes XXX_append

Cheers,

Richard




More information about the poky mailing list