[poky] [PULL] at: Non root install patch is not necessary (Bug 246)

[Mei, Lei]

Hi Richard,
    I have added the description to the nonstripbinaries.patch, please check it, thank you~

 meta/recipes-extended/at/at_3.1.12.bb                 |    2 
 meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
 meta/recipes-extended/at/files/nonstripbinaries.patch |   25 ++++++
 3 files changed, 26 insertions(+), 76 deletions(-)

Mei Lei (1):
      at: remove nonrootinstall patch and modify some relevant files

Pull URL: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro

commit 3c695d5d210227c5744fa90736feb7c308c6bf15
Author: Mei Lei <lei.mei at intel.com>
Date:   Thu Oct 21 12:36:51 2010 +0800

    at: remove nonrootinstall patch and modify some relevant files
    
    remove nonrootinstall patch, and use a patch named nonstripbinaries to modify the /at-3.1.10.2/Makefile.in, so it can also handles stripping of the binaries
    
    Fix [BUG 246]
    
    Signed-off-by: Mei Lei <lei.mei at intel.com>

Thanks
Lei

-----Original Message-----
From: Richard Purdie [mailto:rpurdie at linux.intel.com] 
Sent: Wednesday, October 20, 2010 5:25 PM
To: Mei, Lei
Subject: RE: [PULL] at: Non root install patch is not necessary (Bug 246)

On Wed, 2010-10-20 at 17:05 +0800, Mei, Lei wrote:
> Hi Richard,
>    I have re-fixed this bug, please check it, thank you~
> 
>  meta/recipes-extended/at/at_3.1.12.bb                 |    2 
>  meta/recipes-extended/at/files/nonrootinstall.patch   |   75 ------------------
>  meta/recipes-extended/at/files/nonstripbinaries.patch |   21 +++++
>  3 files changed, 22 insertions(+), 76 deletions(-)
> 
> Mei Lei (1):
>       at: remove nonrootinstall patch and modify relevant files

Thanks, much better. One more small thing though - could you add a
header to the patch with a description of what it does, why and who made
the change. In this case its fairly obvious but its a good idea in
general as when you come back to a patch six months later you can
remember why its there!

Also, poky pull requests like this should be going to the Poky mailing
list.

Cheers,

Richard