[poky] [PATCH 2/3] bitbake: Introduce stamp-extra-info into build stamp file

Richard Purdie richard.purdie at linuxfoundation.org
Wed Jan 12 03:48:44 PST 2011


On Tue, 2011-01-11 at 12:11 +0000, Joshua Lock wrote:
> Hi Dongxiao,
> 
> I've done a quick style review of this patch, comments inline.
> 
> On Tue, 2011-01-11 at 14:18 +0800, Dongxiao Xu wrote:
> > For certain tasks, we need additional information in build stamp file
> > except the task name and file name. stamp-extra-info is introduced as
> > an flag adding to the end of stamp file name.
> > 
> > Besides, if we need to add common flags for tasks, we can set value for
> > macro BB_STAMP_EXTRA.
> > 
> > Signed-off-by: Dongxiao Xu <dongxiao.xu at intel.com>

I talked with Dongxiao about this patch and we agreed the best approach
will be to make bb.build.stampfile() the main entry point so most users
will be converted to use that and then the datacache vs d ugliness can
be contained in one place (stamp_internal) which calls into siggen.

Josh is right about the 0/1 vs. False/True though. Values of 0/1 are
used in many places in the code but we're trying to clean it up as we
update things.

Cheers,

Richard




More information about the poky mailing list