[poky] [PATCH 1/1] systemtap: new package

[Tom Zanussi]

On Thu, 2011-01-13 at 13:36 -0800, Darren Hart wrote:
> On 01/13/2011 11:55 AM, Tom Zanussi wrote:
> > Add systemtap, a general-purpose script-directed dynamic tracing and
> > performance analysis tool for Linux.
> >
> > Signed-off-by: Tom Zanussi<tom.zanussi at intel.com>
> > ---
> >   .../conf/distro/include/poky-default-revisions.inc |    1 +
> >   meta/recipes-core/tasks/task-poky-tools.bb         |    1 +
> >   meta/recipes-kernel/systemtap/systemtap_git.bb     |   28 ++++++++++++++++++++
> >   3 files changed, 30 insertions(+), 0 deletions(-)
> >   create mode 100644 meta/recipes-kernel/systemtap/systemtap_git.bb
> >
> > diff --git a/meta/conf/distro/include/poky-default-revisions.inc b/meta/conf/distro/include/poky-default-revisions.inc
> > index 6b98091..c07e2c7 100644
> > --- a/meta/conf/distro/include/poky-default-revisions.inc
> > +++ b/meta/conf/distro/include/poky-default-revisions.inc
> > @@ -165,6 +165,7 @@ SRCREV_pn-screenshot ??= "292"
> >   SRCREV_pn-settings-daemon ??= "2059"
> >   SRCREV_pn-swabber-native ??= "a0792390c5d6d5a5bade7ab155c80eef3f30fa52"
> >   SRCREV_pn-sysprof ??= "38a6af1f0a45e528fd2842983da71e0f23c70d6a"
> > +SRCREV_pn-systemtap ??= "4ab3a1863bf4f472acae7a809bf2b38d91658aa8"
> >   SRCREV_pn-table ??= "4b267533ce16656cba4104fc39dc12709c1bdddf"
> >   SRCREV_pn-tasks ??= "ea52d46d691c5fce4473ea4e24a35411381f3a65"
> >   TRACECMDREV ?= "6c696cec3f264a9399241b6e648f58bc97117d49"
> > diff --git a/meta/recipes-core/tasks/task-poky-tools.bb b/meta/recipes-core/tasks/task-poky-tools.bb
> > index 60a95f9..c23a3fe 100644
> > --- a/meta/recipes-core/tasks/task-poky-tools.bb
> > +++ b/meta/recipes-core/tasks/task-poky-tools.bb
> > @@ -51,6 +51,7 @@ RRECOMMENDS_task-poky-tools-profile = "\
> >       kernel-module-oprofile \
> >       blktrace \
> >       sysprof \
> > +    systemtap \
> >       "
> >
> >   #    exmap-console
> > diff --git a/meta/recipes-kernel/systemtap/systemtap_git.bb b/meta/recipes-kernel/systemtap/systemtap_git.bb
> > new file mode 100644
> > index 0000000..f28c946
> > --- /dev/null
> > +++ b/meta/recipes-kernel/systemtap/systemtap_git.bb
> > @@ -0,0 +1,28 @@
> > +DESCRIPTION = "SystemTap - script-directed dynamic tracing and performance analysis tool for Linux"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
> > +
> > +DEPENDS = "elfutils"
> 
> I remember (from a couple years ago) systemtap being very dependent on 
> the elfutils version. Do we need to have a way to indicate a specific 
> version - or minimum version - so that systemtap doesn't suddenly break 
> without a helpful warning?
> 

Yeah, if it's that fragile, we probably want to lock down a known good
version...

> Otherwise, looks good to me.
> 

Thanks for reviewing it!

Tom