[poky] [PATCH 10/12] dates: fix build issue with gcc dso linking change

[Mark Hatle]

On 1/17/11 4:45 PM, Nitin A Kamble wrote:
> All the libraries needs to be specified explicitely with the new gcc dso
> linking change patch. This was causing build errors for this
> recipe. Specifying the libm and libpango-1.0 libraries explicitely for
> linking to work without errors.
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>

...

> +Nitin A Kamble <nitin.a.kamble at intel.com>
> +Date: 2011/01/11
> +
> +Index: git/src/Makefile.am
> +===================================================================
> +--- git.orig/src/Makefile.am
> ++++ git/src/Makefile.am
> +@@ -34,6 +34,6 @@ dates_SOURCES = $(platform) 	\
> + 	gconf-bridge.h		\
> + 	gconf-bridge.c
> + 
> +-dates_LDADD = $(DATES_LIBS) $(OWL_LIBS) libgtkdatesview.la
> ++dates_LDADD = $(DATES_LIBS) $(OWL_LIBS) libgtkdatesview.la -lm -lpango-1.0

Only concern I have with this patch is that, at first glance it looks like there
might be a problem with the libgtkdatesview.la or one of the existing $(...)
items causing the missing dependency.

I'd like to make sure that the .la files have been inspected and verify they do
not require libm or libpango.  Assuming they do not, could you add a comment to
the patch indicating that's been checked so when the next person looks they
won't be confused by whats going on.

--Mark

> + 
> + MAINTAINERCLEANFILES = config.h.in Makefile.in
> diff --git a/meta/recipes-sato/pimlico/dates_git.bb b/meta/recipes-sato/pimlico/dates_git.bb
> index bceeec6..973c42d 100644
> --- a/meta/recipes-sato/pimlico/dates_git.bb
> +++ b/meta/recipes-sato/pimlico/dates_git.bb
> @@ -6,9 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
>                      file://src/gconf-bridge.c;endline=22;md5=ad7626c6daf4aec590474a243f4912fa"
>  
>  PV = "0.4.11+git${SRCPV}"
> -PR = "r2"
> +PR = "r3"
>  
>  S = "${WORKDIR}/git"
>  
>  SRC_URI = "git://git.gnome.org/${PN};protocol=git \
> -	   file://make-382.patch"
> +	   file://make-382.patch \
> +	   file://dso_linking_change_build_fix.patch"