[poky] [PATCH 12/12] screenshot: fix build issue with gcc dso linking change

[Mark Hatle]

On 1/17/11 4:45 PM, Nitin A Kamble wrote:
> All the libraries needs to be specified explicitely with the new gcc dso
> linking change patch. This was causing build errors for this
> recipe. Specifying the libX11 libgdk-x11-2.0 and libgdk_pixbuf-2.0 libraries
> explicitely for linking to work without errors.
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> ---

...

> +Index: screenshot/Makefile.am
> +===================================================================
> +--- screenshot.orig/Makefile.am
> ++++ screenshot/Makefile.am
> +@@ -23,4 +23,4 @@ endif
> + # A standalone tool for running from a terminal and scripts
> + bin_PROGRAMS = screenshot
> + screenshot_SOURCES = main.c
> +-screenshot_LDADD = $(GTK_LIBS) libshot.la
> ++screenshot_LDADD = $(GTK_LIBS) libshot.la -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lX11

Similar to the last one.  On first look, the GTK_LIBS or libshot.la might be
incorrect causing this failure.  If it's been verified that both GTK_LIBS values
and the libshot.la match the contents of the library.... and these things are
application specific the change is fine.. I'd just like a comment explaining that.

--Mark

> diff --git a/meta/recipes-sato/screenshot/screenshot_svn.bb b/meta/recipes-sato/screenshot/screenshot_svn.bb
> index 35f3422..ff2b7c8 100644
> --- a/meta/recipes-sato/screenshot/screenshot_svn.bb
> +++ b/meta/recipes-sato/screenshot/screenshot_svn.bb
> @@ -10,8 +10,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>  PRIORITY = "optional"
>  DEPENDS = "matchbox-panel-2"
>  PV = "0.0+svnr${SRCPV}"
> +PR = "r1"
>  
> -SRC_URI = "svn://svn.o-hand.com/repos/misc/trunk;module=${PN};proto=http"
> +SRC_URI = "svn://svn.o-hand.com/repos/misc/trunk;module=${PN};proto=http\
> +	file://dso_linking_change_build_fix.patch"
>  
>  S = ${WORKDIR}/${PN}
>