[poky] [PATCH 5/9] insane.bbclass: skip checks on .la installed status

[Koen Kooi]

Op 19 jan 2011, om 19:27 heeft Scott Garman het volgende geschreven:

> On 01/18/2011 11:19 PM, Koen Kooi wrote:
>> Op 19 jan 2011, om 05:19 heeft Scott Garman het volgende geschreven:
>> 
>>> Enabling libtool sysroot support triggers these errors but they
>>> are a valid change in behavior.
>> 
>> Based on the RPATH discussion off-list, should we add a check for RPATH pointing to staging as well? I know RPs patches fix it, but it would be nice to catch if it starts happening again.
> 
> By staging I assume you're referring to the sysroot dir? If so, we do have that QA check in insane.bbclass already (see package_qa_check_rpath), and I have been relying on it to detect the problems I was reporting. This patch doesn't alter or remove that.

And indeed it does have that already, time to 'port' that to OE :)

> 
> If I'm misunderstanding, feel free to correct me.
> 
> Scott
> 
>>> 
>>> Signed-off-by: Scott Garman<scott.a.garman at intel.com>
>>> ---
>>> meta/classes/insane.bbclass |    5 -----
>>> 1 files changed, 0 insertions(+), 5 deletions(-)
>>> 
>>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>>> index 3ab4c2c..6f06d85 100644
>>> --- a/meta/classes/insane.bbclass
>>> +++ b/meta/classes/insane.bbclass
>>> @@ -427,11 +427,6 @@ def package_qa_check_staged(path,d):
>>>             path = os.path.join(root,file)
>>>             if file.endswith(".la"):
>>>                 file_content = open(path).read()
>>> -                # Don't check installed status for native/cross packages
>>> -                if not bb.data.inherits_class("native", d) and not bb.data.inherits_class("cross", d):
>>> -                    if installed in file_content:
>>> -                        error_msg = "%s failed sanity test (installed) in path %s" % (file,root)
>>> -                        sane = package_qa_handle_error(5, error_msg, "staging", path, d)
>>>                 if workdir in file_content:
>>>                     error_msg = "%s failed sanity test (workdir) in path %s" % (file,root)
>>>                     sane = package_qa_handle_error(8, error_msg, "staging", path, d)
>>> --
>>> 1.7.1
>>> 
>>> _______________________________________________
>>> poky mailing list
>>> poky at yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/poky
>> 
> 
> 
> -- 
> Scott Garman
> Embedded Linux Distro Engineer - Yocto Project