[poky] [PATCH 1/3] bitbake: add ${MACHINE} for do_populate_sysroot_setscene and do_package_setscene

Xu, Dongxiao dongxiao.xu at intel.com
Thu Jan 27 23:54:03 PST 2011


Richard Purdie wrote:
> On Thu, 2011-01-27 at 16:04 +0800, Dongxiao Xu wrote:
>> From: Dongxiao Xu <dongxiao.xu at intel.com>
>> 
>> ${MACHINE} information is also needed to be tagged on stamps for
>> do_populate_sysroot_setscene and do_package_setscene, otherwise if
>> build two machines both from sstate, the second machine's sysroot
>> will not be populated correctly. 
>> 
>> Signed-off-by: Dongxiao Xu <dongxiao.xu at intel.com>
> 
> The _setscene stuff is really an internal implementation issue within
> bitbake. I don't like the idea that the metadata has to get this
> right and I'd prefer it if bitbake always did the right thing. In
> this case that means looking up the extra stamp info against the
> parent task, not the setscene one.    
> 
> I therefore merged:
> 
> http://git.pokylinux.org/cgit.cgi/poky/commit/?id=c34913ea5a4f20ce4bca3c68a65e9f64f1e3910c

Yes, this approach is better then specifically handling *_setscene stamp-extra-info in meta files. Thanks!

-- Dongxiao

> 
> which should obsolete this patch?
> 
> Good catch on finding the problem though!
> 
> Cheers,
> 
> Richard




More information about the poky mailing list