[poky] [PATCH 1/5] gcc: Add "--enable-clocale=gnu" option explicitly

Tian, Kevin kevin.tian at intel.com
Sun Jan 30 20:36:17 PST 2011


> From: Wold, Saul
> Sent: Monday, January 31, 2011 5:07 AM
> 
> On 01/30/2011 12:11 AM, Tian, Kevin wrote:
> >> From: Jingdong Lu
> >> Sent: Sunday, January 30, 2011 3:36 PM
> >>
> >> From: Jingdong Lu<jingdong.lu at windriver.com>
> >>
> >> Add "--enable-clocale=gun" option for gcc configuration explicitly in order to
> >> make sure C++ library can use correct locale module.
> >>
> >> Signed-off-by: Jingdong Lu<jingdong.lu at windriver.com>
> >> ---
> >>   meta/recipes-devtools/gcc/gcc-configure-common.inc |    2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> >> b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> >> index 4393777..b212fdc 100644
> >> --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
> >> +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
> >> @@ -27,7 +27,7 @@ EXTRA_OECONF_INTERMEDIATE ?= ""
> >>
> >>   GCCMULTILIB = "--disable-multilib"
> >>
> >> -EXTRA_OECONF = "${@['--enable-clocale=generic',
> >> ''][bb.data.getVar('USE_NLS', d, 1) != 'no']} \
> >> +EXTRA_OECONF = "${@['--enable-clocale=generic', '
> >> --enable-clocale=gnu'][bb.data.getVar('USE_NLS', d, 1) != 'no']} \
> >>                   --with-gnu-ld \
> >>                   --enable-shared \
> >>                   --enable-languages=${LANGUAGES} \
> >> --
> >> 1.7.0.4
> >>
> >
> > PR bump is expected for all gcc recipes affected by this change.
> >
> Yes, I agree with Kevin on this, also what is the impact to generated
> binaries?  Does this add any size to compiled binaries?
> 

This actually reminds me one optional task in original 1.0 planning, to provide a better
option level configurability for user's deep customization requirement. Now similarly
we need this level of configurability to extend one recipe for different purpose...

Thanks
Kevin



More information about the poky mailing list