[poky] [PATCH 1/1] poky-lsb: Change provider of virtual/libx11 to libx11-trim

[Richard Purdie]

On Tue, 2011-07-05 at 16:23 -0700, Saul Wold wrote:
> On 07/05/2011 08:13 AM, Richard Purdie wrote:
> > On Fri, 2011-07-01 at 17:36 +0800, Xiaofeng Yan wrote:
> >> From: Xiaofeng Yan<xiaofeng.yan at windriver.com>
> >>
> >> BUG 1196 reports  compilation error like the following information from package startup-notification  when the provider of virtual/libx11 was libx11
> >> | configure: error: Cannot find x11-xcb
> >> | ERROR: oe_runconf failed
> >> | ERROR: Function 'do_configure' failed (see
> >>
> >> Fix [BUGID #1196]
> >> Signed-off-by: Xiaofeng Yan<xiaofeng.yan at windriver.com>
> >> ---
> >>   meta-yocto/conf/distro/poky-lsb.conf |    2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/meta-yocto/conf/distro/poky-lsb.conf b/meta-yocto/conf/distro/poky-lsb.conf
> >> index 49d12da..5385012 100644
> >> --- a/meta-yocto/conf/distro/poky-lsb.conf
> >> +++ b/meta-yocto/conf/distro/poky-lsb.conf
> >> @@ -4,6 +4,6 @@ DISTRO = "poky-lsb"
> >>   DISTROOVERRIDES = "poky:linuxstdbase"
> >>
> >>   DISTRO_FEATURES_append = " pam largefile"
> >> -PREFERRED_PROVIDER_virtual/libx11 = "libx11"
> >> +PREFERRED_PROVIDER_virtual/libx11 = "libx11-trim"
> >>
> >
> > This looks like a backwards step. Why is libx11 not pulling in xcb as I
> > suspect it should be...
>
> The x11-xcb, seems to be part of libx11-trim, so possibly creating a new 
> recipe that that peels x11-xcb from libx11-trim is possibly another 
> approach. The xcb packages don't seem to provide x11-xcb directly.

Er, ok...

libx11, libx11-trim and libx11-diet are three different variants of the
same libx11 recipe that vary in the options they enable/disable.

Reading the comments for -trim it says "Support for XCB disabled in this
version" and then goes on to enable it. Basically anything in trim
should also be in libx11 so we should probably enable XCB there too.

IIRC, someone told me XCB was mandatory now so I'm a little surprised
the libx11 recipe works at all tbh.

I also gather -diet might be broken to the point of being unusable
now :/. This whole area needs a rethink in the light of DISTRO_FEATURES
really.

Short term, the correct patch is likely one to enable XCB for libx11...

Cheers,

Richard