[poky] [PATCH 0/2] LSB: add nspr and nss to pass LSB library check

[Colin Walters]

On Fri, Mar 25, 2011 at 2:52 AM, Kang Kai <kai.kang at windriver.com> wrote:
> From: Kang Kai <kai.kang at windriver.com>
>
> add nss and nspr to provide libnss3.so, libssl3.so and libnspr4.so
> to pass LSB library check.
> Both are imported from oe, rev 6fe7cef27069415f2eba36bc640cf59013d4979b

I'm new to Yocto but have been around in the general purpose distro
land for a while, and there is one thing that has always driven me
nuts: patches without any comment.
This may not be your fault, but:

Take for example b/meta/recipes-extended/mozilla/nspr-4.8.7/unbreak-build.diff

*why*?  Who wrote the patch?  What was broken?  Has the patch ever
been sent upstream?

Personally I tend to hand-write something similar to "git
format-patch" if I'm not actually creating a patch against upstream
git (which I try hard to do).

meta/recipes-extended/mozilla/nspr-4.8.7/30_config_64bits.dpatch

is one that clearly should be upstream, it's just way saner.

Planning to use nspr in my tree, so thought I'd take a look =)
Otherwise looks pretty clean to me.