[poky] Fwd: Please help to review the Yocto 1656: Recipe creation/import script

Joshua Lock josh at linux.intel.com
Thu Jan 19 17:57:41 PST 2012



On 19/01/12 01:33, Kang Kai wrote:
> Hi Josh,
>
> The attachment is the the design document V2 and implement.
>
> The V2 document changes are:
> 1 remove patch_set from argument list
> 2 deb is not support right now
>
> Any comment is welcome.
> And I will on vacation until Jan 30, so my reply may not in time.

This looks like a good start, Paul has offered some great feedback. In 
addition I'd add that we need a license header on the script, we should 
probably attribute autospectacle in the header too (Inspired by? Based on?).

I haven't had chance to do a thorough code review but will try and do so 
whilst you're on your break.

Cheers,
Joshua
-- 
Joshua Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre



More information about the poky mailing list