[poky] [PATCH 1/1] meta-yocto: Define DISTRO in layer.conf

[Carl Simonson]

On Thu, Mar 29, 2012 at 8:23 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Thu, 2012-03-29 at 20:01 +0800, Dongxiao Xu wrote:
>> Add the definition of DISTRO variable in meta-yocto/conf/layer.conf,
>> and remove the corresponding definition in local.conf.sample.
>>
>> As we know, if we source oe-init-build-env in Yocto project environment,
>> we will have DISTRO="poky" set in local.conf by default, where the
>> "poky" DISTRO comes from the meta-yocto layer. If user deletes
>> meta-yocto layer from BBLAYERS in bblayers.conf, and then error will
>> happen when bitbake parsing the local.conf, since it could not find
>> where the "poky" DISTRO comes from.
>>
>> Putting the DISTRO definition in layer.conf to avoid defining two
>> related variables (DISTRO and BBLAYERS) in two separate
>> configuration files (local.conf and bblayers.conf).
>>
>> Signed-off-by: Dongxiao Xu <dongxiao.xu at intel.com>
>> ---
>>  meta-yocto/conf/distro/poky.conf  |    1 -
>>  meta-yocto/conf/layer.conf        |    1 +
>>  meta-yocto/conf/local.conf.sample |    4 ++--
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> I'm afraid this is the wrong approach. The UI should simply not allow
> selection of a DISTRO option which is no longer available.
>
> Setting DISTRO in local.conf is the way people expect to use the system
> and we can't change that.
>
> Cheers,
>
> Richard
>
> _______________________________________________
> poky mailing list
> poky at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky

Agreed. It's important that DISTRO remains in local.conf. Remember,
also, that local.conf.sample is only a suggestion as to how to
configure your build. The real configuration is in
build/conf/local.conf, and that is meant to be changed freely.

Carl Simonson
simonsonc at gmail.com