[poky] Patch kernel.py to prevent a crash from yocto-bsp

Tom Zanussi tom.zanussi at intel.com
Wed Nov 13 10:19:26 PST 2013


On Wed, 2013-11-13 at 18:57 +0100, Bastien JAUNY wrote:
> Hello there,
> 
> I found that if the build environment is misconfigured (e.g. a bad path
> for a layer in bblayers.conf) the yocto-bsp script crashes with a
> standard python error, not very explicit.
> 
> First time I use mailing lists, I hope I did everything right! :)

Hi,

Thanks for your patch, it looks like it will fix the problem.

Just a couple things, though, if you wouldn't mind resubmitting:

- please don't submit patches as attachments, but rather submit them
in-line i.e. use 'insert as text' in your mailer, for example, rather
than 'as attachment'.

- please include the text explaining the problem and fix in the commit
message e.g. 'If the build environment is misconfigured (e.g. a bad path
for a layer in bblayers.conf) the yocto-bsp script crashes with a
standard python error, not very explicit.  This fixes the problem'

- please preface the subject with the component and a short one-line
description e.g. instead of:

 'Fix an error message in python bsp script, preventing a
 crash with a python error in case of a misconfiguration.'

something more like:

 'yocto-bsp: Add missing format specifier in bblayers error message'

Thanks,

Tom

> _______________________________________________
> poky mailing list
> poky at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky





More information about the poky mailing list