[poky] [PATCH 1/9] Fix "configure: error: gbm requires --enable-dri"

[Jussi Kukkonen]

On 1 October 2015 at 21:01, Jens Rehsack <rehsack at gmail.com> wrote:

>
> Signed-off-by: Jens Rehsack <sno at netbsd.org>
> ---
>  meta/recipes-graphics/mesa/mesa.inc | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa.inc
> b/meta/recipes-graphics/mesa/mesa.inc
> index af7a2c4..13a8b9d 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -37,11 +37,9 @@ PACKAGECONFIG[wayland] = ",,wayland"
>  DRIDRIVERS = "swrast"
>  DRIDRIVERS_append_x86 = ",radeon,r200,nouveau,i965,i915"
>  DRIDRIVERS_append_x86-64 = ",radeon,r200,nouveau,i965,i915"
> -PACKAGECONFIG[dri] = "--enable-dri --with-dri-drivers=${DRIDRIVERS},
> --disable-dri, dri2proto libdrm"
> +PACKAGECONFIG[dri] = "--enable-dri --with-dri-drivers=${DRIDRIVERS}
> --enable-gbm, --disable-dri, dri2proto libdrm"
>  PACKAGECONFIG[dri3] = "--enable-dri3, --disable-dri3, dri3proto
> presentproto libxshmfence"
>
> -EXTRA_OECONF += "--enable-gbm"
> -
>

Martins generic comments apply but on top of that: Please add a short
explanation. I would have expected gbm to get enabled from
PACKAGECONFIG[egl] but possibly I don't understand the whole context: are
there EGL users who do not want GBM?. Also, if you use --enable-gdm
conditionally, you should --disable-gbm in the other case: otherwise mesa
autodetects and that might be non-deterministic (now or in future).

Jussi


>  PACKAGECONFIG[gles] = "--enable-gles1 --enable-gles2, --disable-gles1
> --disable-gles2"
>
>  EGL_PLATFORMS  = "drm"
> --
> 1.9.1
>
> --
> Jens Rehsack - rehsack at gmail.com
>
> --
> _______________________________________________
> poky mailing list
> poky at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/poky/attachments/20151002/c723a413/attachment.html>