[poky] rootfs-postcommands "cmd<space>;<space"

[Thomas Hughes]

I wanted to stop the *-<ts>.testdata.json from filling up my dirs
by using ROOTFS_POSTPROCESS_COMMAND_remove="write_image_test_data;"
(... why that's not being auto cleaned up is a legitimate question,
but actually not the purpose of this email/patch ...)

My plan works great if rootfs-postcommands.bbclass did not add
(?some?) commands using "cmd ; " ... with an extra <space>.

Is there some other/better way to remove one POSTPROCESS cmd?
(... without using "elaborate" inline python magic?)
Is there any reason to keep extra <space> characters in there?

Could someone please consider/commit this .patch wherever it
needs to go, to make it into the next poky release?
The attached .patch was based on /poky-contrib/ last week.
(Sorry, my email client(s) mangle the .patch "inside" email)


"summary" of the attached patch:

    avoid [SPACE] so ROOTFS_POSTPROCESS_COMMAND_remove="cmd;" works
    example of this problem: "x ; y ; z;"
    ..._remove="y" causes "x ; ; z;" (invalid cmd '')
    ..._remove="y ;" causes "x z;" (invalid cmd 'x z')
...
diff --git a/meta/classes/rootfs-postcommands.bbclass
...
-ROOTFS_POSTPROCESS_COMMAND ... "zap_empty_root_password ; ",d)}'
+ROOTFS_POSTPROCESS_COMMAND ... "zap_empty_root_password; ",d)}'
... 
-ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp ; "
+ROOTFS_POSTPROCESS_COMMAND += "rootfs_update_timestamp; "
...
-ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data ; "
+ROOTFS_POSTPROCESS_COMMAND += "write_image_test_data; "
...
-ROOTFS_POSTUNINSTALL_COMMAND =+ "write_image_manifest ; "
+ROOTFS_POSTUNINSTALL_COMMAND =+ "write_image_manifest; "
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ROOTFS_POSTPROCESS_no_space.txt
URL: <http://lists.yoctoproject.org/pipermail/poky/attachments/20180814/7228a0bf/attachment.txt>