[poky] [PATCH 4/6] wic: bootimg-partition: Add support to create the u-boot boot config file

[Kevin Hao]

On Thu, Aug 16, 2018 at 10:09:02AM -0400, Tom Rini wrote:
> On Tue, Aug 14, 2018 at 09:31:24AM +0800, Kevin Hao wrote:
> 
> > By leveraging the distro boot command feature in the u-boot, we can
> > compose the corresponding extlinux.conf when creating the wic image,
> > and let u-boot boot the kernel automatically. For more detail about
> > the u-boot distro boot command feature, please see doc/README.distro
> > in u-boot source files.
> > 
> > Signed-off-by: Kevin Hao <kexin.hao at windriver.com>
> 
> It doesn't look like this has the ability to provide an external
> extlinux.conf file like is done for other loaders, but should.

Yes. I noticed the custom conf support in other loaders. But I chose to keep
the first version patch as simple as possible. I would make an addon patch to
add that function.

> 
> [snip]
> > +        # The kernel types supported by the sysboot of u-boot
> > +        kernel_types = ["uImage", "zImage", "Image", "vmlinux", "fitImage"]
> 
> This order isn't the best order.

In the current code, only one of these kernel images can be added in the
'IMAGE_BOOT_FILES'. If it find multi kernel images, it just throw an error and
exit. So the order really doesn't matter at all.

>  We should look for zImage (stock arm32
> image), Image (stock arm64 image), fitImage (preferred container in
> U-Boot) then uImage (legacy container in U-Boot).

OK, I will adjust the order as your suggested and select the preferred
kernel image if multi kernel images are found.


>  While I'm sure just
> vmlinux can work in some cases, I don't think it's appropriate here.

One of the board supported by meta-yocto-bsp (edgerouter) does use the vmlinux image.
So I would keep it.

Thanks,
Kevin

> 
> -- 
> Tom


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.yoctoproject.org/pipermail/poky/attachments/20180820/eb47db9d/attachment.pgp>