[poky] [PATCH] poky.conf: Define SDK_VERSION so DISTRO_VERSION overrides are supported
Christopher Larson
kergoth at gmail.com
Fri Jan 18 08:40:36 PST 2019
The commit message covers the := -> =, but doesn’t mention the switch to
getVar. I’m assuming it’s similar to the base-files fix when referencing an
undefined variable, but is it really needed in this context?
On Fri, Jan 18, 2019 at 8:49 AM Peter Kjellerstedt <
peter.kjellerstedt at axis.com> wrote:
> If DISTRO_VERSION is defined using an override, e.g., by defining it
> in auto.conf as DISTRO_VERSION_forcevariable, then the unoverridden
> value was still used in SDK_VERSION since it was defined using the :=
> operator. However, there should be no reason to define SDK_VERSION
> this way.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
> ---
> meta-poky/conf/distro/poky.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-poky/conf/distro/poky.conf
> b/meta-poky/conf/distro/poky.conf
> index f5de8f2335..73d200ebbd 100644
> --- a/meta-poky/conf/distro/poky.conf
> +++ b/meta-poky/conf/distro/poky.conf
> @@ -3,7 +3,7 @@ DISTRO_NAME = "Poky (Yocto Project Reference Distro)"
> DISTRO_VERSION = "2.6+snapshot-${DATE}"
> DISTRO_CODENAME = "master"
> SDK_VENDOR = "-pokysdk"
> -SDK_VERSION :=
> "${@'${DISTRO_VERSION}'.replace('snapshot-${DATE}','snapshot')}"
> +SDK_VERSION = "${@d.getVar('DISTRO_VERSION').replace('snapshot-${DATE}',
> 'snapshot')}"
>
> MAINTAINER = "Poky <poky at yoctoproject.org>"
>
> --
> 2.12.0
>
> --
> _______________________________________________
> poky mailing list
> poky at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/poky/attachments/20190118/efa5de53/attachment-0001.html>
More information about the poky
mailing list