[Toaster] [review-request] sstate file information fix

[Chisanovici, IonutX]

Hi all,

Got it, the test will be added asap.

Cheers,
IonutC

From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
Sent: Monday, March 31, 2014 6:48 PM
To: Barros Pena, Belen; Chisanovici, IonutX
Cc: toaster at yoctoproject.org
Subject: Re: [Toaster] [review-request] sstate file information fix

I've found the bug about the "cached" tasks you've reported below, and corrected it.
About the automated test, it makes sense. Pinging Ionut about this (CC).

Alex


On Thu, Mar 27, 2014 at 5:53 PM, Barros Pena, Belen <belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>> wrote:
On 27/03/2014 15:11, "Damian, Alexandru" <alexandru.damian at intel.com<mailto:alexandru.damian at intel.com>>
wrote:

>Hi again,
>
>After a bug signalled by Belen, I have a new push for review here:
>
>
>adamian/20140327-sstatefix
This is what I can see. The file names make sense and the couple of them
I've manually checked do exist in my sstate-cache directory. But:

For Cached tasks (the ones that found the file), the file name finishes
with the signature number, so the file name is missing the _taskname and
the extension (.tgz). For native recipes, the path also seems to be
missing the host architecture directory at the very beginning (in my case,
Ubuntu-12.04).

For Executed tasks with a missed sstate attempt (the ones that did not
find the file), the file name comes complete, with the task name and the
.tgz extension. The path also seems complete.

So getting there :)

I think we might need a new automated test that checks if the
path_to_sstate_obj database entries for Cached tasks exist in the sstate
directory. What do you think?


>
>
>Can you please review ?
>
>Thank you,
>Alex
>
>
>
>
>On Tue, Mar 25, 2014 at 4:18 PM, Damian, Alexandru
><alexandru.damian at intel.com<mailto:alexandru.damian at intel.com>> wrote:
>
>Hello,
>
>This is a review request for a patch that brings in sstate file
>information
>
>Can you please review poky-contrib branch adamian/20140325-sstatefix ?
>
>
>Thanks,
>Alex
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>



--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140401/085aea86/attachment.html>