[Toaster] questions about 6040: build date picker

[Reyna, David]

Hi Belen,

I have a preliminary implementation for 6040 which adds support for selecting a date range for build started and build completed, a feature my group agrees is very important.

My preliminary commit is here (rebased as of Friday night) : dreyna/build_datepicker_6040

I have some questions and issues though:

1) I enabled the "datepicker" Javascript by including "jquery-ui.js" in "build.html". However this file is some 400k in size, which seems excessive especially for a home page. Do we want to extract the "datepicker" et. al. scripts into a smaller file?

2) I copied and added the 'jquery-ui-1.10.3.custom.min.css' from your Toaster website so that the background colors for the datapicker would be valid. I however find that the month forward and back buttons are invisible. Do you know what CSS we need to adjust to get them visible again?

3) We have a multitude of date formats, and I image that they change for Europe.

  (a) The build page shows in my page "dd/mm/yy"
  (b) The filters want "yyyy-mm-dd"
  (c)  The datepicker returns "mm/dd/yyyy"

I have enabled the code to convert "mm/dd/yyyy" and "yyyy/mm/dd" internally to "yyyy-mm-dd" for the filter (and illegal date formats are converted to 'today').

I am concerned however that we allow users to directly edit the date fields, and especially that they might think that the build tables date field ("dd/mm/yy") is expected. Should I add that as a supported format? Is it different for Europe??

4) I am finding that the backend is not processing my composite date ranges as expected. I get it to work for "yesterday", which is for example "filter=completed_on__gte;completed_on__lt:2014-04-05;2014-04-06", but other ranges return the wrong set.

For example, "filter=completed_on__gte;completed_on__lt:2014-03-01;2014-03-02" returns all of my April builds.

I am not sure how tested "_get_filtering_query" is for these extended formats, or maybe I am not using it correctly. That is perhaps a question for Alex? Could you ping him?

- David


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140407/710ace0c/attachment.html>