[Toaster] [review-request] 5996 The "URI(s) searched" information in the task details page is empty

[Barros Pena, Belen]

On 08/04/2014 17:42, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belén,
>
>> It's because the way you have the tags nested.
>
>I have updated my commit: dreyna/uri_paths_5996

Yep, spacing sorted. Thanks!

>
>Thanks,
>David
>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>> Sent: Tuesday, April 08, 2014 8:43 AM
>> To: Reyna, David
>> Cc: toaster at yoctoproject.org
>> Subject: Re: [review-request] 5996 The "URI(s) searched" information in
>>the
>> task details page is empty
>>
>>
>> On 08/04/2014 04:37, "Reyna, David" <david.reyna at windriver.com> wrote:
>>
>> >Hi Belén,
>> >
>> >I have implemented 5996 as per Alex¹s comments.
>>
>> This seems to be working, although I haven't had time to run a build
>>with
>> some mirrors set.
>>
>> >Please note that in my Firefox (Win7 28.0) the URI list insists on
>> >starting on the next line after the label ³URI(s) searched² when the
>> >³<code>² tag is present. Perhaps this does not happen in your browser?
>>
>> It's because the way you have the tags nested. This is what you have in
>> line 166 of task.html
>>
>> <dd><code><ul>{% for uri in uri_list %}<li>{{uri}}</li><% endfor
>> %}</ul></code></dd>
>>
>> But you should have:
>>
>> <dd><ul>{% for uri in uri_list %}<li><code>{{uri}}</code></li><% endfor
>> %}</ul></dd>
>>
>> With the <code> tag nested inside the <li> tag. That should solve the
>> spacing problem.
>>
>> >
>> >The branch is here: dreyna/uri_paths_5996
>> >
>> >I simulated a SSTATE_MIRRORS value with this example from the Yocto
>> >documentation page:
>> >
>> >    SSTATE_MIRRORS = "\
>> >             file://.* http://someserver.tld/share/sstate/PATH \n \
>> >             file://.* file:///some/local/dir/sstate/PATH"
>>
>> I will set and test this.
>>
>> >
>> >- David
>> >
>> >p.s. who uses Œ\n¹ as an entry delimiter?? Why not Œ:¹ or even Œ;¹?
>> >
>> >
>>
>