[Toaster] [review-request] 6040 Implement "from ... to" option in the "Started on" and "Completed on" filters

Reyna, David david.reyna at windriver.com
Tue Apr 8 20:08:17 PDT 2014


Hi Belén,

Thanks to yours and Alex's help, I have completed the date range selection for the build page.

The branch is here: dreyna/build_datepicker_6040

This commit is on top of Alex's commit: "bitbake: toaster: fix filtering query for multiple filters" ( adamian/20140408-getfilteringquery<http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20140408-getfilteringquery> )

[ Implementation Notes ]

  * The date format error handling is done in the python class, where as a rule today's date is substituted for bad dates. This code also automatically swaps date ranges when they are in reverse order. An enhancement (when we have more time) is to move this code to the javascript side.

  * The new feature is keyed by an option having the value of "from-to", which we can do since this option is user selected and there is no good single value to pass. A later enhancement would to pass the current range to preset the to-from values. When this is set, a new option[4] field is added which passes a prefix so that the generated code can uniquely connect the instance of filter to the respective jquery methods in "main.js".

* Since the "__lte" does not work for dates - it does an "__le" instead - the "to" date is internally incremented by one day to convert an inclusive date to an exclusive one.

  * The "from" variable is given the name "filter" to allow the normal interface code to work, and the "to" variable is unique. That is caught in the view class, the two dates are normalized and joined into a full filter, and "_redirect_parameters" is called to pass a clean filter URL context back to the "build" class.

- David


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140409/e2110879/attachment.html>


More information about the toaster mailing list