[Toaster] [review-request] license manifest link

[Barros Pena, Belen]

On 08/04/2014 23:28, "Wymore, Farrell" <Farrell.Wymore at windriver.com>
wrote:

>Hi Belen,
>
>I amended this commit/push. I believe the correct columns should appear.

Just checked this: it is not going to do.

2 problems: 

1. The link to the license manifest information should not be in the
license manifest path (the <dd> tag), it should be in the <dt> tag, as
shown here:

http://www.yoctoproject.org/toaster/build-dashboard.html

2. The link actually changes the list of columns available for the table
(see attached screenshot). This should not happen. I should still have
checkboxes for all the columns (Dependencies, Layer, Layer branch, Layer
commit, Layer directory, License, Package, Package version, Recipe, Recipe
version, Reverse dependencies, Size, Size over total), but only the
following should be checked (and therefore visible):

* Package
* Package version
* License
* Recipe

I hope this makes sense. Any questions, let me know.

Cheers

Belén


>
>This code should be refactored - which I plan to do. I mainly wanted to
>push
>the corrected behavior today.  Thanks is advance.
>
>    - fw
>
>
>-----Original Message-----
>From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>Sent: Monday, April 07, 2014 3:00 AM
>To: Wymore, Farrell
>Cc: toaster at yoctoproject.org
>Subject: Re: [review-request] license manifest link
>
>On 04/04/2014 20:27, "Wymore, Farrell" <Farrell.Wymore at windriver.com>
>wrote:
>
>>Hi Belen,
>>
>>Please review the fwymore/license-target.  This corrects bug #5936.
>
>I think this if for 6079
>
>The link is now going to the right page, but when you get there you
>should see the same information that is included in the license manifest
>document, which means the installed packages table should be showing only
>the following columns:
>
>* Package
>* Package version
>* License
>* Recipe
>
>
>>
>>Should the ŒPackages included¹ value/link go to the same place.  If so,
>>its an easy change.
>
>Yes, but a patch for that was merged over the weekend, so no need to
>worry about it:
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=9db433246fbab66a
>6
>46ce9188d7f9b096df8552b
>
>
>I also moved the license manifest link from the <dd> tag to the <dt> tag
>
>Cheers
>
>Belén
>
>>
>>Thanks in advance.
>>
>>-
>>fw
>>
>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: license-manifest-checkboxes.png
Type: image/png
Size: 138564 bytes
Desc: license-manifest-checkboxes.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140409/ca1b6885/attachment-0001.png>