[Toaster] V2: Commit for recipe detail view ready for review

Fri Jan 17 17:13:45 PST 2014

Hi all,

* I have pushed my Version 2 commit (dreyna/recipe-detail-view-v2) for the recipe details page for review. There are two separate commits for tracking purposes. (I tried to modify my V1 push, but it did not take).

* I have fixed the issues identified by Belen, except that I have a question with the issue "small layout issue that makes the heading and the tabs not to align properly".

I do not see this issue. Moreover, here is the HTML layout as reflected by Firebug:

  HTML file             Schema
  -------------------- --------------------
  base                |    <body>
  base                |        <div class="navbar navbar-static-top"></div>
  base                |        <div class="container-fluid">
  basebuilddetailpage |          <div class="">
  basebuilddetailpage |            <div class="section"></div>
  basebuilddetailpage |            <div class="row-fluid">
  recipe              |                <div class="row span11"></div>
  recipe              |                <div class="row span7 tabbable"></div>
  recipe              |                <div class="row span4 well"></div>
  basebuilddetailpage |            </div>
  basebuilddetailpage |          </div>
  base                |        </div>
  base                |    </body>

The page follows Belen's advised layout, with slight variations in "basebuilddetailpage.html", but that file follows the same layout as "basebuilddetailpage.html" which I inherited.

Belen, what alignment artifacts do you see?

- David

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> Sent: Friday, January 17, 2014 8:14 AM
> To: Reyna, David
> Cc: toaster at yoctoproject.org
> Subject: Re: Commit for recipe detail view ready for review
> 
> Hi David,
> 
> Thanks for pushing this: it¹s looking great :)
> 
> From a UI standpoint, the page seems to have a small layout issue that
> makes the heading and the tabs not to align properly. To fix it, the
> body
> structure should look like this:
> 
> <body>
>     <div class=³navbar navbar-static-top²></div>
>     <div class=³container-fluid²>
>         <div class=³row-fluid²>
> 	    <div class=³section²></div>
> 	    <div class=³row span11²></div>
> 	    <div class=³row span7 tabbable²></div>
> 	    <div class=³row span4 well²></div>
>         </div>
>     </div>
> </body>
> 
> You need to add the class row-fluid to the child of container-fluid,
> and
> remove the div with class row-fluid that is a sibling of the div with
> class section. That will align all content nicely.
> 
> Only 3 other things:
> 
> 1. Next to the layer name you are showing the blue icon that links to
> the
> layer index. We currently have an issue with this that we still don¹t
> know
> how to solve (see 5192 in Bugzilla). Can we take the icon out for the
> moment until we find the right solution?
> 
> 2. I am finding recipes that report no tasks in their tasks table (see
> attached image). This should not happen, and in fact when you go to the
> tasks list there are tasks for those recipes.
> 
> 3. The Bugtracker value seems to have a trailing / (see attached
> image).
> So if there is no bugtracker specified for the recipe, the / shows. If
> any
> of the variables used to populate the information about the recipe is
> not
> specified in the recipe file, we simply don¹t show them. For example,
> if
> there is no bugtracker, we show only summary, description, homepage,
> section and license.
> 
> Any questions, let me know.
> 
> Cheers
> 
> Belén
> 
> 