[Toaster] git push - set page title

[Ravi Chintakunta]

Hi Alex,

Comments inline.

From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
Sent: Thursday, January 16, 2014 12:03 PM
To: Ravi Chintakunta
Cc: toaster at yoctoproject.org
Subject: Re: git push - set page title

Hello, Ravi.
I am gonna comment here on the whole set of patches :).
- Title: please use  "bitbake: toaster: " as the start of all subject lines. This helps with merging upstream, and makes some porting scripts between oe-core and bitbake trees work :)
I cleaned up my previous commits and added bitbake: toaster:
- Title needs to be a bit more descriptive. Ie. instead of "Base table enhancements" - "Base table fix sorting header link and icon"
Handled in my latest commit.
- Please squash all "All Tasks" patches in a single one, since functionally it's all about a single thing - getting the task table to work.
Done.
The code itself looks good to me.

Thanks,
Ravi



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140118/62c3c737/attachment.html>