[Toaster] V2: Commit for recipe detail view ready for review

[Barros Pena, Belen]

On 21/01/2014 11:47, "Paul Eggleton" <paul.eggleton at linux.intel.com> wrote:

>On Tuesday 21 January 2014 11:39:08 Richard Purdie wrote:
>> On Tue, 2014-01-21 at 11:21 +0000, Paul Eggleton wrote:
>> > On Tuesday 21 January 2014 11:07:18 Reyna, David wrote:
>> > > Hi Belen,
>> > > 
>> > > > Just came across a Homepage: unknown (in the recipe
>> > > > update-rc.d-native). The recipe has no HOMEPAGE variable set
>> > > 
>> > > But, it does have a value (that is returned from the database), and
>>that
>> > > value happens to be the literal string "unknown". The code is only
>> > > testing
>> > > whether or not the value is defined and is not of length zero - all
>>else
>> > > is
>> > > up to the database.
>> > > 
>> > >         {% if object.homepage %}
>> > >         
>> > >             <dt>Homepage</dt>
>> > >             <dd><a
>> > >             href="{{object.homepage}}">{{object.homepage}}</a></dd>
>> > >         
>> > >         {% endif %}
>> > > 
>> > > Now, if you want me to add an additional test in the code for the
>> > > literal
>> > > string "unknown", then I can certainly do that, but that would be a
>> > > hard-coded literal string added to the template code.
>> > 
>> > The default value from meta/conf/bitbake.conf is "unknown", and it's
>>been
>> > that way since the early OE-Classic days. I honestly don't know why
>>that
>> > is the default, I'd personally prefer if it was blank. Assuming
>>OE-Core
>> > keeps that default though we're going to see a lot of these.
>> 
>> Lets change the default?
>
>Probably a good idea. I'll send a patch.

Wondrous. Thank you.

>
>Cheers,
>Paul
>
>-- 
>
>Paul Eggleton
>Intel Open Source Technology Centre
>_______________________________________________
>toaster mailing list
>toaster at yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster