[Toaster] git push for base html, base table, custom tags, fitler dialog and All Tasks feature to ravi/all-tasks-feature

[Damian, Alexandru]

Hi Ravi,

I did not understand at first your comment about
> if the cookie is not set (user visits the page for the first time and
does not change the columns visibility) then all the columns are being
displayed.

I think you need to add

'hidden' : 1

in the tablecols[] entry for the column you want to hide by default.

Cheers,
Alex


On Wed, Jan 22, 2014 at 2:57 AM, Ravi Chintakunta <
ravi.chintakunta at timesys.com> wrote:

> Hi Alex,
>
>
>
> I have fixed the builds view so that the filters  work  well and pushed it
> to ravi/all-tasks-feature branch.
>
>
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/bitbake/lib/toaster?h=ravi/all-tasks-feature&id=dfde36b1f9131af4a20d683196eb619e2813d0c8
>
>
>
> Thanks,
>
> Ravi
>
>
>
> *From:* Damian, Alexandru [mailto:alexandru.damian at intel.com]
> *Sent:* Tuesday, January 21, 2014 9:49 AM
>
> *To:* Ravi Chintakunta
> *Cc:* Paul Eggleton; Barros Pena, Belen; Reyna, David L (Wind River);
> Lerner, David M (Wind River); Zhang, Jessica; toaster at yoctoproject.org
> *Subject:* Re: git push for base html, base table, custom tags, fitler
> dialog and All Tasks feature to ravi/all-tasks-feature
>
>
>
> Hi Ravi,
>
> You're right, I added the cookie functionality. I think this is how it
> should work :).
>
> About the patches, the commits look right; yet the last patch breaks the
> filters on the "Build Dashboard" page. We can't take patches that break
> other things, so can you please update the settings for "Build" page as
> well to work with the new filter code ?
>
> Cheers,
> Alex
>
>
>
> On Mon, Jan 20, 2014 at 7:50 PM, Ravi Chintakunta <
> ravi.chintakunta at timesys.com> wrote:
>
> Hi Alex,
>
>
>
> I rebased my code on top of master, resolved conflicts, fixed the code to
> reflect master code changes, changed the order of the commits of views and
> filter dialog and pushed it to my branch ravi/all-tasks-feature.
>
>
>
> Please review and let me know.
>
>
>
> I noted that you changed the show/hide of table columns to use cookie. I
> just wanted to let you know that this is working when the cookie is set
> (that is the user has changed the columns visibility), but if the cookie is
> not set (user visits the page for the first time and does not change the
> columns visibility) then all the columns are being displayed.
>
>
>
> Thanks for your help,
>
> Ravi
>
>
>
> *From:* Damian, Alexandru [mailto:alexandru.damian at intel.com]
> *Sent:* Monday, January 20, 2014 10:11 AM
>
>
> *To:* Ravi Chintakunta
> *Cc:* Paul Eggleton; Barros Pena, Belen; Reyna, David L (Wind River);
> Lerner, David M (Wind River); Zhang, Jessica; toaster at yoctoproject.org
> *Subject:* Re: git push for base html, base table, custom tags, fitler
> dialog and All Tasks feature to ravi/all-tasks-feature
>
>
>
> Hi,
>
> 1. I applied the patches in order, and after each patch tested to see if
> things still work. I expect on each patch in a patchset to leave things in
> an workable state, no unresolved dependencies in a future patch. So if I
> need to apply a views.py patch, that should come either before this patch,
> or, if there is a circular dependency (i.e. views and templates change
> together), the changes must be part of the same patch.
>
> 2. yes, you need to rebase on top of toaster/master; the way that I do it:
>
> - I have a local toaster/master which follows upstream
> poky-contrib/toaster/master
>
> - I have my development branch based on the local toaster/master
>
> When I need to rebase,
>   - I do git pull on the local toaster/master branch, and then
>   - move to the development branch and do git rebase -i toaster/master
>
> Hope this helps,
> Alex
>
>
>
>
>
> On Mon, Jan 20, 2014 at 2:54 PM, Ravi Chintakunta <
> ravi.chintakunta at timesys.com> wrote:
>
> Hi Alex,
>
>
>
> 1.      The filter dialog has been changed to use options name and value
> as tuples and that may be the reason you are seeing only the first letters.
> Did you change the code in views.py to set the filter options as tuples?
>
> 2.      To check that the All tasks feature patch applies, should I fetch
> from toaster/master and then rebase?
>
>
>
> Thanks,
>
> Ravi
>
>
>
> *From:* Damian, Alexandru [mailto:alexandru.damian at intel.com]
> *Sent:* Monday, January 20, 2014 7:16 AM
> *To:* Ravi Chintakunta
> *Cc:* Paul Eggleton; Barros Pena, Belen; Reyna, David L (Wind River);
> Lerner, David M (Wind River); Zhang, Jessica; toaster at yoctoproject.org
> *Subject:* Re: git push for base html, base table, custom tags, fitler
> dialog and All Tasks feature to ravi/all-tasks-feature
>
>
>
> Hello,
>
> I have taken in some of the patches in this branch, with changes:
>
> - "viewName" was also implemented, of sorts, as "objectname". I have
> replaced "{{viewName}}" with "{{objectname|title}}" as to capitalize the
> name
>
> - whitespace fixes; please don't do whitespace at the end of a line.
>
>
>
> What I didn't take:
>
> * bitbake: toaster: Filter Dialog fix to display filter options as radio
> buttons
>
> -   The option names are only showing the first letter.
>
> * bitbake: toaster: All Tasks Feature with sorting and filtering
>
> -   Does not apply cleanly on the latest version. Please rebase
>
> -   Whitespace at the end of lines.
>
> Thank you,
> Alex
>
>
>
>
>
>
>
> On Sat, Jan 18, 2014 at 4:20 PM, Ravi Chintakunta <
> ravi.chintakunta at timesys.com> wrote:
>
> I have completed
>
> the All Tasks feature
>
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=4275
>
> and
>
> filtering tasks in a table
>
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=4278
>
> and pushed it to ravi/all-tasks-feature branch:
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=f75622b67a86ff9b14c6ef4b902c324be573e9a1
>
>
>
> The push also includes fixes to:
>
> 1. Base html - to set the title of the page
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=46353d4bfdd8176244599b80b81ed27bf720ddac
>
> 2. Base table - Fix the header text style, sort icon, filter icon
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=426874b4139618dd25a774a7c113097f75938be9
>
> 3. Custom Tags - Added custom tags for setting color based on task
> outcome, filter icon, filter icon tooltip, display zero and other values as
> blank.
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=ac2f8b18d2a728efb0b5bccce6be7f9e5acb467b
>
> 4. Filter Dialog - Modified it to display the filter options as radio
> buttons, and changed the filter options data structure from dictionary to
> list so that the order of the filter options is preserved.
>
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-tasks-feature&id=2a8742d6e7ce75cd9b6f854874b2ac15a58a45ab
>
> Few of these were pushed previously, but now I have cleaned up the commit
> message and grouped multiple commits based on the functionality.
>
> Please review and let me know what you think.
>
> Thanks,
> Ravi
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>
>
>
>
> --
>
> Alex Damian
>
> Yocto Project
>
> SSG / OTC
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140122/9f04ddb7/attachment-0001.html>