[Toaster] V2: Commit for recipe detail view ready for review

[Barros Pena, Belen]

On 23/01/2014 20:23, "Reyna, David" <david.reyna at windriver.com> wrote:

>> ³Can you please rebase these latest fixes as a new patch on top of
>>toaster/master?²
>
>
>Done! See ³dreyna/recipe-detail-view².
> 
> 
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/re
>cipe-detail-view 
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/r
>ecipe-detail-view>

Hi David,

Just had a quick look to the branch and realised that package size is
being displayed in bytes, instead of being converted to KB or MB as
appropriate. Any chance we could get that changed?

Thanks!

Belén

Thanks!
> 
>- David
> 
> 
>From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
>
>Sent: Thursday, January 23, 2014 4:43 AM
>To: Reyna, David
>Cc: belen.barros.pena at intel.com
>Subject: Re: [Toaster] V2: Commit for recipe detail view ready for review
>
>
> 
>Hi David,
>
>
>I already taken in toaster-master the previous version of
>
>bitbake: toaster: Implementation of recipe detail views
>
>Can you please rebase these latest fixes as a new patch on top of
>toaster/master ?
>
>Thank you,
>
>Alex
>
>
> 
>On Tue, Jan 21, 2014 at 8:27 PM, Reyna, David <david.reyna at windriver.com>
>wrote:
>Hi Alex,
> 
>* Ok, I fixed the formatting errors. The ³<div class="tab-pane" Š>² did
>not want a ³name² attribute,
> and the ³<th>² was missing a wrapping ³<tr>².
> 
>* I see now that ³Firebug² saw the ³<th>² error, but it marked it subtle
>red that I had to manually
> scroll and look out for (and did not complain about the ³<div class²
>issue at all). If there is an error dialog or listing for Firebug I have
>not found it, so this is a shy tool as far as errors go.
> 
>* I then used ³HTMLValidator², which immediately gave me the results that
>you observed. I fixed them,
> and I get a HTML5 pass, but now I seeŠ
> 
>  "0 errors / 3 warnings"
>                  
>
>Š but no list of the supposed warnings anywhere. I have tried serial
>mode, tidy mode alone, plus
> the online mode. All say 3 warnings but no details. In my Google
>searches there are it seems always explicit warnings listing with this
>message. There are also mentions here and there are sometimes false and
>empty warnings. It is maddening.
> 
>* I have pushed the fixed commit in any case.
> 
>- David
> 
>From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
>
>Sent: Tuesday, January 21, 2014 10:20 AM
>To: Reyna, David
>Cc: belen.barros.pena at intel.com
>
>Subject: Re: [Toaster] V2: Commit for recipe detail view ready for review
>
>
>
>
> 
>I removed the div with row-fluid and moved the row-fluid class to the
>outer-most div.
>
>It doesn't affect the HTML5 validation.
>
>The errors I get in the Recipe detail page are:
>
>line 122 column 73 - Error: Attribute name not allowed on element div at
>this point.
>line 155 column 24 - Error: th start tag in table body.
>line 519 column 72 - Error: Attribute name not allowed on element div at
>this point.
>line 575 column 68 - Error: Attribute name not allowed on element div at
>this point.
>line 584 column 70 - Error: Attribute name not allowed on element div at
>this point.
>
>Cheers,
>
>Alex
>
> 
>
>
> 
>On Tue, Jan 21, 2014 at 5:48 PM, Reyna, David <david.reyna at windriver.com>
>wrote:
>What was the adjustment? I am curious if that aFfects the HTML5
>valilidation, or its parent page
> basebuildpage.html.
>
>David
>
> 
>From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
>
>
>Sent: Tuesday, January 21, 2014 05:30
> AM
>
>To: Reyna, David 
>Cc: Barros Pena, Belen <belen.barros.pena at intel.com>
>
>
>Subject: Re: [Toaster] V2: Commit
> for recipe detail view ready for review
>
>
> 
>
>Merged ! Congrats !
>
>I just had a couple of modifications:
>
>- debuged the alignment issue with Belen and had a small change in
>basebuilddetailpage.html
>
>- whitespace at the end of line; i.e, there should not be whitespace on
>any line before \n; I use s/[[:space:]]\+$// to make sure I don't
> whitespace :)
>
>Alex
>
> 
>
>
> 
>On Tue, Jan 21, 2014 at 1:16 PM, Damian, Alexandru
><alexandru.damian at intel.com> wrote:
>Looks ok to me, I'm gonna test and take it into toaster-master if it
>tests ok :)
>
>Alex
>
>
> 
>On Tue, Jan 21, 2014 at 12:46 PM, Reyna, David
><david.reyna at windriver.com> wrote:
>Hi Alex and Balen,
>
>So, with the below decision, does my submission get a pass :-)?
>
>- David
>
>> -----Original Message-----
>> From: toaster-bounces at yoctoproject.org [mailto:toaster-
>> bounces at yoctoproject.org] On Behalf Of Barros Pena, Belen
>> Sent: Tuesday, January 21, 2014 3:57 AM
>> To: Paul Eggleton; Richard Purdie
>> Cc: toaster at yoctoproject.org
>> Subject: Re: [Toaster] V2: Commit for recipe detail view ready for
>> review
>>
>>
>>
>
>> On 21/01/2014 11:47, "Paul Eggleton" <paul.eggleton at linux.intel.com>
>> wrote:
>>
>> >On Tuesday 21 January 2014 11:39:08 Richard Purdie wrote:
>> >> On Tue, 2014-01-21 at 11:21 +0000, Paul Eggleton wrote:
>> >> > On Tuesday 21 January 2014 11:07:18 Reyna, David wrote:
>> >> > > Hi Belen,
>> >> > >
>> >> > > > Just came across a Homepage: unknown (in the recipe
>> >> > > > update-rc.d-native). The recipe has no HOMEPAGE variable set
>> >> > >
>> >> > > But, it does have a value (that is returned from the database),
>> and
>> >>that
>> >> > > value happens to be the literal string "unknown". The code is
>> only
>> >> > > testing
>> >> > > whether or not the value is defined and is not of length zero -
>> all
>> >>else
>> >> > > is
>> >> > > up to the database.
>> >> > >
>> >> > >         {% if object.homepage %}
>> >> > >
>> >> > >             <dt>Homepage</dt>
>> >> > >             <dd><a
>> >> > >
>> href="{{object.homepage}}">{{object.homepage}}</a></dd>
>> >> > >
>> >> > >         {% endif %}
>> >> > >
>> >> > > Now, if you want me to add an additional test in the code for
>> the
>> >> > > literal
>> >> > > string "unknown", then I can certainly do that, but that would
>> be a
>> >> > > hard-coded literal string added to the template code.
>> >> >
>> >> > The default value from meta/conf/bitbake.conf is "unknown", and
>> it's
>> >>been
>> >> > that way since the early OE-Classic days. I honestly don't know
>> why
>> >>that
>> >> > is the default, I'd personally prefer if it was blank. Assuming
>> >>OE-Core
>> >> > keeps that default though we're going to see a lot of these.
>> >>
>> >> Lets change the default?
>> >
>> >Probably a good idea. I'll send a patch.
>>
>> Wondrous. Thank you.
>>
>> >
>> >Cheers,
>> >Paul
>> >
>> >--
>> >
>> >Paul Eggleton
>> >Intel Open Source Technology Centre
>> >_______________________________________________
>> >toaster mailing list
>> >toaster at yoctoproject.org
>> >https://lists.yoctoproject.org/listinfo/toaster
>>
>> _______________________________________________
>> toaster mailing list
>> toaster at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
>
>
>
>
>--
>
>Alex Damian
>
>Yocto Project
>
>SSG / OTC 
>
>
>
>
>
>
>
>
>-- 
>Alex Damian
>
>Yocto Project
>
>SSG / OTC 
>
>
>
>
>
>
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>
>
>
>
>
>
>
>
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>
>
>