[Toaster] Status on implementation of review comments
Barros Pena, Belen
belen.barros.pena at intel.com
Mon Jan 27 07:18:51 PST 2014
On 27/01/2014 14:58, "Lerner, Dave" <dave.lerner at windriver.com> wrote:
>Hi Belen,
>I never got the invite that I thought you were going to send. Are we
>still on for 10:0am Central Time (utc-6:00)?
>Do you have a conference number or webex number?
Sorry, Dave: I thought you would send the invite. Some miscommunication
there :) We don't have Webex, so I was hoping you could set it up.
I've only just started to look into the branch you sent on Friday, so I
could do with a bit more time. Do you think we could move this to
tomorrow, same time?
Thanks!
Belén
>-Dave
>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>> Sent: Wednesday, January 22, 2014 11:33 AM
>> To: Lerner, Dave; Damian, Alexandru
>> Cc: toaster at yoctoproject.org; Reyna, David
>> Subject: Re: Status on implementation of review comments
>>
>> On 22/01/2014 14:57, "Lerner, Dave" <dave.lerner at windriver.com> wrote:
>>
>> >Hi Belen, Alex
>> >
>> >Here is the status and some comments/questions on Belen's
>> >comments/issues.
>> >
>> >The inline comments note that I'm very close to full implementation of
>> >all comments, with only one outstanding review bullet item which should
>> >be done in a few hours.
>> >
>> >However, I will need another afternoon to rebase and retest before I
>>push
>> >a new commit and request a review. Since you won't be around Friday,
>> >Monday morning (UTC-6:00) seems more likely than tomorrow morning for a
>> >verbal review.
>>
>> Monday morning works for me. We'll need Webex for this. Do you want to
>> send an invite around?
>>
>> I've answered your questions in line
>>
>> Thanks for all the work!
>>
>> Belén
>>
>> >
>> >Regards,
>> >Dave
>> >
>> >> -----Original Message-----
>> >> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>> >> Sent: Friday, January 17, 2014 12:03 PM
>> >> To: Lerner, Dave; toaster at yoctoproject.org
>> >> Subject: Re: Commit pushed for comments on style, correct pattern
>> >>implemenation, testing
>> >> undocumented
>> >>
>> >> Hi Dave,
>> >>
>> >> Thanks for the branch. I have a few comments on the UI side (mostly
>> >>small
>> >> details):
>> >>
>> >> * Layout: this page uses exactly the same layout structure as the
>>recipe
>> >> details page. The body structure should look like this:
>> >>
>> >> <body>
>> >> <div class="navbar navbar-static-top"></div>
>> >> <div class="container-fluid">
>> >> <div class="row-fluid">
>> >> <div class=³section"></div>
>> >> <div class="row span11"></div>
>> >> <div class="row span7 tabbable"></div>
>> >> <div class="row span4 well"></div>
>> >> </div>
>> >> </div>
>> >> </body>
>> >
>> >Done.
>> >
>> >> The span11 div contains the <h1> that should have the page-header
>>class
>> >> applied. The span7 has the tabs and tab content, and the span4 has
>>the
>> >> package information.
>> >
>> >Done.
>> >
>> >> * In the built package details page, the help bubble should be to the
>> >>left
>> >> of the tab labels, not to the right
>> >
>> >Done.
>> >
>> >> * In the built package details page, the content of the alert-info
>> >>should
>> >> not have the lead class applied. It shouldn¹t need the internal <div
>> >> class=³row-fluid lead²></div>
>> >
>> >Done.
>> >
>> >> * In the ŒGenerated files¹ tab , in the alert-info, the name of the
>> >>recipe
>> >> should be bold (needs a <strong> tag)
>> >
>> >By recipe name do you mean <package><version><revision>?
>>
>> Yes, that’s what I meant, sorry.
>>
>> >
>> >
>> >> * In the ŒGenerated files¹ tab and the ³File in the root file system²
>> >>tab
>> >> tables, the file names should not have the <strong> tag
>> >
>> >Done.
>> >
>> >>
>> >> * In the file and dependency tables, can we use the symbol B for
>>bytes
>> >> instead of the full word?
>> >
>> >Done. Implemented new projecttags template filter filesizeformatYocto.
>> >
>> >> * In the ŒRuntime dependencies¹ tab, can we change the ŒOther runtime
>> >> relationships¹ heading to h3?
>> >
>> >Done.
>> >I assume that you wanted this for both 'built' and 'included' views
>> >showing 'Other dependencies',
>> >correct?
>>
>> Yes, that's correct.
>>
>> >
>> >> * In the ŒRuntime dependencies¹ tab, the number of dependencies
>>between
>> >> brackets should match the number of entries in the RDEPENDS/TRDEPENDS
>> >> table (currently it shows the number of entries in that table plus
>>the
>> >> number of entries in the ŒOther runtime relationships¹ table)
>> >
>> >Done.
>> >I assume that you wanted this for both 'built' and 'included' views
>> >showing 'Other dependencies',
>> >correct?
>>
>> Yes, that's correct.
>>
>> >
>> >> * In the dependency tables, all table cells should be a link to the
>> >> corresponding build or installed package details page, unless the
>> >>package
>> >> has not been built. If the package has not being built, the size
>>cell is
>> >> empty (I can see that the version information is not available for
>>such
>> >> packages, which is ok), and we apply the .muted class to the row
>> >
>> >In progress.
>> >
>> >>
>> >> * In the built packages page, for packages installed in a target,
>>I¹ve
>> >> used <div class=³lead well²> instead of the <div class=³alert
>> >>alert-info²>
>> >> If we want to keep the alert info, we can do <div class=³alert
>> >>alert-info
>> >> lead²> and get rid of the child <div class=³row-fluid lead²>
>> >
>> >Done. I followed your sample code: <div class="lead well">
>> >
>> >> * In the installed package details page, the name of the target (for
>> >> example, core-image-minimal should be within a <small></small> tag
>> >
>> >Done
>> >
>> >> * In the built packages page, if a package has no
>>RDEPENDS/TRDEPENDS, we
>> >> don¹t show the ³<package_name> is not included in any image² alert.
>>We
>> >> only show the ³<package_name> has no runtime dependencies² alert.
>>Also,
>> >> that alert text should not mention RDEPENDS.
>> >
>> >Done
>> >
>> >> * The names of the relationship types should be ŒRecommends¹,
>> >>ŒProvides¹,
>> >> ŒSuggests¹, ŒReplaces¹ and ŒConflicts¹, instead of Œrrecommends¹ etc.
>> >>Next
>> >> to each of them we should have a help bubble that displays on hover
>> >>
>> >> <i class="icon-question-sign get-help hover-help" title=³ "></i>
>> >
>> >Question : Ok for the help bubble to be on the right to prevent
>>jiggling
>> >of the relationship string? If so, Done.
>>
>> Yes. The bubble in this case should be to the right of the relationship
>> name.
>>
>> >
>> >>
>> >> The title values are as follows:
>> >>
>> >> ** For ŒRecommends¹: This package extends the usability of
>> >><package_name>
>> >> ** For ŒProvides¹: This package is provided by <package_name>
>> >> ** For ŒSuggests¹: This package is suggested for installation with
>> >> <package_name>
>> >> ** For ŒReplaces¹: This package is replaced by <package_name>
>> >> ** For ŒConflicts¹: This package conflicts with <package_name>, which
>> >>will
>> >> not be installed if this package is not first removed
>> >> You can see an example at
>> >> http://www.yoctoproject.org/toaster/package-included-details.html
>> >
>> >Done.
>> >
>> >> * The Other relationship types table should be sorted by relationship
>> >> type, and then by package name (right now it seems to be sorted by
>> >>package
>> >> name). The relationship types are listed in this order:
>> >>
>> >> 1. Recommends
>> >> 2. Suggests
>> >> 3. Provides
>> >> 4. Replaces
>> >> 5. Conflicts
>> >
>> >Done.
>> >
>> >> * In the package information, the size seems to be coming in bytes.
>>It
>> >> should show exactly in the same way as we show it in the dependency
>> >>tables
>> >
>> >Done.
>> >
>> >> * In the package information, can we remove or comment out the
>>license
>> >> files until we store that information in the database?
>> >
>> >Done
>> >
>> >> If you have any questions, let me know.
>> >>
>> >> Cheers
>> >>
>> >> Belén
>> >>
>> >>
>> >>
>> >>
>> >> On 16/01/2014 17:50, "Lerner, Dave" <dave.lerner at windriver.com>
>>wrote:
>> >>
>> >> >Yes. Sorry for that omission.
>> >> >-dave
>> >> >
>> >> >> -----Original Message-----
>> >> >> From: Damian, Alexandru [mailto:alexandru.damian at intel.com]
>> >> >> Sent: Thursday, January 16, 2014 11:45 AM
>> >> >> To: Lerner, Dave
>> >> >> Cc: Eggleton, Paul (paul.eggleton at intel.com); Barros Pena, Belen
>> >> >> (belen.barros.pena at intel.com); Reyna, David; Ravi Chintakunta
>> >> >> (ravi.chintakunta at timesys.com); jessica.zhang at intel.com;
>> >> >>toaster at yoctoproject.org
>> >> >> Subject: Re: Commit pushed for comments on style, correct pattern
>> >> >>implemenation, testing
>> >> >> undocumented
>> >> >>
>> >> >> Is this the http://git.yoctoproject.org/cgit/cgit.cgi/poky-
>> >> >> contrib/log/?h=lerner/package-detail-views-bz4328 branch ?
>> >> >>
>> >> >> Alex
>> >> >>
>> >> >>
>> >> >>
>> >> >> On Thu, Jan 16, 2014 at 5:36 PM, Lerner, Dave
>> >> >><dave.lerner at windriver.com> wrote:
>> >> >>
>> >> >>
>> >> >> Hi Alex, Paul, Belen
>> >> >>
>> >> >> I've pushed a commit to
>> >> >>poky-contrib(ssh://git@git.yoctoproject.org/poky-contrib)
>> >> >> for review on style, correct pattern implementation (doing things
>>in
>> >> >>templates vs views
>> >> >> and vice versa), all other newbie related issues.
>> >> >>
>> >> >> TESTING
>> >> >> -------
>> >> >> While I have tested each flow and item, I have not documented
>>these
>> >> >>tests and will
>> >> >> do so after I fix the templates and code per your recommendations.
>> >> >>Then, I will update
>> >> >> the branch as necessary and send out another review request.
>> >> >> To summarize the build set that I used for testing:
>> >> >> * core-image-minimal qemuarm
>> >> >> * core-image-sato qemux86
>> >> >> * core-image-base, core-image-minimal genericx86
>> >> >>
>> >> >> UNIMPLEMENTED FEATURES
>> >> >> ----------------------
>> >> >> The unimplemented features are documented in the commits. The
>> >>latest
>> >> >>round of
>> >> >> discussions on RvsT dependencies is not yet impelmented. And if I
>> >> >>don't get any further
>> >> >> feedback, I will implement per Belen's latest comments.
>>Dependency
>> >> >>ordering will be
>> >> >> discussed in another email.
>> >> >>
>> >> >> COMMITS
>> >> >> -------
>> >> >> There are two commits, urls.py and 'everything else'. The two
>> >>commits
>> >> >>are
>> >> >> summarized as follows:
>> >> >> --------------
>> >> >> commit aa179a36be6b39f44204476299f51658a25c7bd3
>> >> >> Author: Dave Lerner <dave.lerner at windriver.com>
>> >> >> Date: Wed Jan 15 14:25:28 2014 -0600
>> >> >>
>> >> >> Implementation of package detail views
>> >> >>
>> >> >> The commit includes changes to implement package detail
>>views.
>> >>The
>> >> >> views divide into
>> >> >> a) package detail and dependency views when not installed in
>>any
>> >> >>image
>> >> >> b) package detail and link to more detail when selected from
>>a
>> >> >>build
>> >> >> view
>> >> >> c) package detail, dependency views, and reverse dependency
>> >>views
>> >> >>when
>> >> >> selected from an image view
>> >> >>
>> >> >> The views are based on specifications found in attachments to
>> >> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=4328
>> >> >> with (a), (b) specified in design-1.5.1-package-details and
>> >> >> (c) specified in design-1.1.1-included-package-details.
>> >> >>
>> >> >> Not all of the features are implemented in this commit. The
>>next
>> >> >>section
>> >> >> describes stubs or unimplemented features.
>> >> >>
>> >> >> 1 Variance in all views:
>> >> >> 1.1 Filesize units are implemented using the django template
>> >> >>built-in
>> >> >> filesizeformat filter. This filter differs from the spec as
>> >> >>follows:
>> >> >> (MB, KB, B) are shown with the filter as (MB, KB, bytes)
>> >> >> The filter does not strip trailing '.0' numbers.
>> >> >> 1.2 In the Package information sidebar the following fields
>>are
>> >>not
>> >> >> implemented or only partially implemented:
>> >> >> License files (see bugzilla 5648)
>> >> >> Layer (the url unconditionally points to
>> >> >>
>>layers.openembedded.org/layerindex/branch/master/layers/
>> >> >> 1.3 Lists that should show RDEPENDS also show TRDEPENDS types
>> >>and
>> >> >> lists that should show RRECOMMENDS also show TRRECOMENDS
>>types.
>> >> >> 1.4 Relationship strings are as encoded in the relationship
>> >> >>defining
>> >> >> python dictionary, not per capitalized and stripped of
>>leading
>> >>'r'.
>> >> >>
>> >> >> 2 Variance to Package Detail views when not in image (or
>> >>selected
>> >> >>via
>> >> >> builds page, that is 1.5.1 specification above)
>> >> >> 2.1 Dependency tab interactivity is not implemented.
>> >> >> 2.2 Sorting per dependency relation names in the spec is not
>> >> >>implemented.
>> >> >>
>> >> >> 3 Variance to Package Detail views when package is in image
>> >> >> 3.1 The title is all in H1 format, only the package should be
>> >> >><strong>.
>> >> >> 3.2 The rootfs table cell file entry interactivity is not
>> >> >>implemented.
>> >> >> 3.3 Runtime dependency table cell interactivity is not
>> >>implemented.
>> >> >> 3.4 Reverse dependency table cell interactivity is not
>> >>implemented.
>> >> >>
>> >> >> Signed-off-by: Dave Lerner <dave.lerner at windriver.com>
>> >> >>
>> >> >> commit 405223e088c106a3a8dd1ac78af339131633632a
>> >> >> Author: Dave Lerner <dave.lerner at windriver.com>
>> >> >> Date: Wed Jan 15 15:56:13 2014 -0600
>> >> >>
>> >> >> Add urls for package detail views
>> >> >>
>> >> >> This commit adds urls for the package detail views described
>>in
>> >> >> the bugzilla attachments to
>> >> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=4328
>> >> >> The implementation views and templates are in a subsequent
>> >>commit.
>> >> >>
>> >> >> The change adds five detailed package views references.
>> >> >> For a package included in a target:
>> >> >> 1) view for the package detail with files added to the file
>> >>system
>> >> >> 2) view for the runtime dependencies of that package
>> >> >> 3) view for the reverse runtime dependencies of that package
>> >> >> For a package not included in any target of a build:
>> >> >> 4) view for the package detail with files that would be added
>> >> >> 5) view for the runtime dependencies of that package
>> >> >>
>> >> >> Signed-off-by: Dave Lerner <dave.lerner at windriver.com>
>> >> >>
>> >> >> --------------
>> >> >>
>> >> >> I'm looking forward to any and all comments.
>> >> >>
>> >> >> Thanks,
>> >> >> Dave Lerner
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >> --
>> >> >>
>> >> >> Alex Damian
>> >> >> Yocto Project
>> >> >>
>> >> >> SSG / OTC
>> >>
>> >
>>
>
More information about the toaster
mailing list