[Toaster] git push for base html, base table, custom tags, fitler dialog and All Tasks feature to ravi/all-tasks-feature

Barros Pena, Belen belen.barros.pena at intel.com
Wed Jan 29 10:06:22 PST 2014


On 25/01/2014 23:56, "Ravi Chintakunta" <ravi.chintakunta at timesys.com>
wrote:

>Hi Belen,
>
>>  
>>  This is looking good. Just one small thing: the Apply button in the
>>  filter
>>  has the class 'disabled' applied. We should delete that class: it came
>>  from a previous filter design and it is no longer needed.
>>  
>
>I have removed the 'disabled' css class and pushed the commit.
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/all-
>tasks-feature&id=c6b70261ec661e839f26a67960a90daab4246f7f

Thanks, Ravi. The button is looking good.

Just realised something, though. I am not sure if this was working like
this before, or if I only saw it now: none of the filters have a selection
in place when you open them.

Filters are radio button groups, so one of the options must always be
selected by default, since they represent mutually exclusive options. In
the case of the tasks table, all filters should have the "All" option
selected by default, since the table loads showing all tasks.

Any chance that could be fixed at some point?

Thanks!

Belén


>
>Thanks,
>Ravi



More information about the toaster mailing list