[Toaster] image information - problems with database after Paul's push

[Lerner, Dave]

Hi Belen,

The comments are in-line.  To summarize

1)  the ‘image name sort’ bug I fixed in another template, it’s a global bug,

2)  I missed the end anchor tag because I didn’t run html validator, will do that when I’m ready for the next commit

3)  for size/total calculation fields, I haven’t figured out a clean way to present this in it’s column, perhaps a custom template filter.

4)  the worst issue is that I can’t reproduce your problems with the sqlite table that I have.  It could be a mismatch on the values of depends but I’m not sure if you are running an old server that had an old models.py

5)  the config buildvars H1 code has a bug. I’ve implemented the bug-free H1 ‘empty results’ intended syntax which doesn’t match the config buildvars version

6)  not sure what you want for empty.pdf



Cheers and thanks for the hard look,

Dave



> -----Original Message-----

> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]

> Sent: Thursday, March 06, 2014 6:56 AM

> To: Lerner, Dave

> Cc: DAMIAN, ALEXANDRU; Reyna, David

> Subject: Re: image information - problems with database after Paul's push

>

> Dave, this is great work :) It is looking really good. Regarding some of

> your comments:

>

> b) The jquery treetable plugin adds icons like '>' (collapsed), and 'V'

> (expanded) to the rows.  It may be hard to use that time-saving plugin

> without the icons.

>

> This only bothers me when it is next to directories that have no content,

> because it has a title attribute that says "Expand". It would be good to

> hide it in those cases, if at all possible.

>

> c) References that I've found state there is no direct support for table

> row slide animation, although there are a number of work-arounds.  These

> work-arounds aren't obviously usable with the treetable plugin.

>

> The animation is the least of my worries: it is just a nice to have.

>

>

> I have a few additional comments, but they are all pretty small stuff. The

> biggest thing might be an issue with the number of dependencies (packages

> are being counted more than once it seems). There they go:

>

> * In the left navigation, when there is more than one image, they should

> be listed in alphabetical order (in the second build of your db,

> core-image-base should be listed before core-image-minimal)



This is actually in basebuildpage.html, not the spec I worked off of.  But it was trivial to fix and done.



> PACKAGES INCLUDED

>

> * Just to clarify, in the Packages included tab, the size should be the

> sum of sizes of all the packages in the table (not the rootfs file sizes).

> So we should be able to add this information



Done



> * In the package name <td>, I think you forgot to close the anchor tag. It

> should be closed right after the package name:

>

> <td class=³package_name²>

>      <a href=³{% url Œpackage_included_detail¹ build.id target.id

> package.id %}²> {{package.name}} </a>

>



Done.  I to run the page through an html5 validator.  Will run prior to next push.



> * The first time you view the table, the following columns should be

> showing: Package, Package version, Size, Dependencies, Reverse

> dependencies and Recipe. Right now it only shows Package and Package

> version



Done.



> * The package version should be a link to the corresponding included

> package details page, just like the package name is



Done.



> * The size over total should be calculated over the sum of the sizes of

> all the packages in the table, which means we should be able to add that

> information in

>



Non-trivial.  We need

1)  either Alex’s promised table entry (due to passing the query set to a callback paginator)

2)  violate django policy and do the work with an add-in django library that allows math operators in templates,

This should be a bugzilla entry until the database is fixed.  I can add it if you want.



> * In the Dependencies and Reverse dependencies popovers, each package is

> coming in twice (for example, for base-password, you get a 2 in the

> Dependencies button, and when you click it the popover shows ³busybox,

> busybox².

I can’t reproduce this problem.  How did you use the database?  My values counts and packages for dependencies and reverse dependencies match with respect to:

·         popover lists

·         button counts

·         included package detail counts

See examples below



[cid:image001.png at 01CF395A.15AB6E30]





[cid:image002.png at 01CF395A.15AB6E30]





[cid:image003.png at 01CF395A.15AB6E30]

> * I am guessing the above is the reason why the number of dependencies

> showing in the button and the number showing in the installed package

> details pages are different. busybox is a weird example: the reverse

> dependencies button shows 169, but when you click on busybox and go to the

> Reverse runtime dependencies tab in the installed package details page the

> reported number of reverse dependencies is 23

>



Again not reproducible on mine, the popover count for Reverse dependencies matches the installed package details page.  Which image are you looking at in the databse that I sent you ?



[cid:image004.png at 01CF395A.15AB6E30]



after clicking on the package name

[cid:image005.png at 01CF395A.15AB6E30]



> * In the popovers, both Dependencies and Reverse dependencies should be

> sorted in ascending alphabetical order.



Done.



> * There is a small typo in the help text of the Recipe column: the final

> Œe¹ of the word Œpackage¹ is missing (it says Œpackag¹)



Done.



>

> * When I search, the h1 does not give me the number of results returned.

> We can implement this as in the BitBake variables tab in the Configuration

> page (it is slightly different to the design spec, but it works ok and it

> should be easier to do)



Done. But I’ve implemented as *intended* in the Bitbake variables search, but not as it currently runs due to a bug in that code.  If you enter a variable like ZZZZZZ the code clearly indicates it should report ‘No variables’ but it currently shows 0 variables.  I show ‘No packages’ not ‘0 packages’.



>

> * We need to implement the no results page for the search / filters. Once

> more, we should be able to reuse what is in builds.html

There isn’t an example in the Empty.pdf that you developed for the ‘target’ page, for example, core-image-minimal selected with no packages.  DO you want me to follow the spec for 1.5.1?



>

> * Right now the only sortable column seems to be Package. The following

> columns should be sortable as well: Size, Size over total (%), License,

> Recipe, Layer, Layer branch and Layer directory



Done, except for ‘Size over total’ which generates exactly the same row sorting as ‘Size’ which makes sorting on that field redundant. Do we need it?



>

> DIRECTORY STRUCTURE

Will work on all of this tomorrow, no problems apparent from your comments.

I will then push the changes as a 2nd commit in the same view so that you can see the diffs.  But I will collapse the diffs as a single commit for Paul’s preference.





>

> * I am happy with the ³ ³ wrapping the installed_name, but if we add them

> in the Directory structure tab, we should also add them in the Packages

> included tab to keep the presentation nice and consistent :) Otherwise, we

> take them out of the Directory structure tab. I am happy with any of the 2.

> * We need an extra space between the installed_name and help bubble. I

> just added an space in line 103 right before the <i> tag and that works

> fine

>

> * For some reason, the help tooltips don¹t seem to be working when they

> are inside a directory. The .hover-help class does not set the visibility

> to hidden, and the Bootstrap tooltips don¹t start up. I am not sure if

> this is some weird interaction with the table plugin. They do work in the

> ones at the bottom of the table, which are shown by default. If we cannot

> get them to work, we will need to take them out. Maybe Farrell might be

> able to give us a hand with this.

>

> Any questions, let me know.

>

> Cheers

>

> Belén

>

>

>

>

> On 05/03/2014 19:06, "Lerner, Dave" <dave.lerner at windriver.com> wrote:

>

> >Settings.py should not have been added to the branch - my fault.

> >

> >Can you try from your poky repo

> >

> >   git reset HEAD^1 bitbake/lib/toaster/toastermain/settings.py

> >

> >or if you haven't commited my changes then just

> >

> >   git checkout bitbake/lib/toaster/toastermain/settings.py

> >

> >The settings.py file has both the timezone fix (which requires 2 modules)

> >and also points to my local copy of the database which you won't want.

> >

> >Dave

> >

> >> -----Original Message-----

> >> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]

> >> Sent: Wednesday, March 05, 2014 12:39 PM

> >> To: Lerner, Dave; DAMIAN, ALEXANDRU; Reyna, David; Paul Eggleton

> >> (paul.eggleton at linux.intel.com)

> >> Subject: Re: image information - problems with database after Paul's

> >>push

> >>

> >>

> >> On 05/03/2014 00:07, "Lerner, Dave" <dave.lerner at windriver.com> wrote:

> >>

> >> >My new branch for the image 'packages included' and 'directory

> >>structure

> >> >(fake backend)' is in lerner/imaginfo.

> >>

> >> Hi Dave,

> >>

> >> I tried your branch, but when I sourced toaster first I got an error

> >> complaining about pytz. I installed pytz and when I sourced toaster

> >>again

> >> I got this other error:

> >>

> >> The system will start.

> >> Traceback (most recent call last):

> >>   File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,

> >> in <module>

> >>     execute_from_command_line(sys.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 453, in execute_from_command_line

> >>     utility.execute()

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 392, in execute

> >>     self.fetch_command(subcommand).run_from_argv(self.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 263, in fetch_command

> >>     app_name = get_commands()[subcommand]

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 109, in get_commands

> >>     apps = settings.INSTALLED_APPS

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 52, in __getattr__

> >>     self._setup(name)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 47, in _setup

> >>     self._wrapped = Settings(settings_module)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 132, in __init__

> >>     raise ImportError("Could not import settings '%s' (Is it on

> >> sys.path?): %s" % (self.SETTINGS_MODULE, e))

> >> ImportError: Could not import settings 'toastermain.settings' (Is it on

> >> sys.path?): No module named tzlocal

> >> Traceback (most recent call last):

> >>   File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,

> >> in <module>

> >>     execute_from_command_line(sys.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 453, in execute_from_command_line

> >>     utility.execute()

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 392, in execute

> >>     self.fetch_command(subcommand).run_from_argv(self.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 263, in fetch_command

> >>     app_name = get_commands()[subcommand]

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 109, in get_commands

> >>     apps = settings.INSTALLED_APPS

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 52, in __getattr__

> >>     self._setup(name)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 47, in _setup

> >>     self._wrapped = Settings(settings_module)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 132, in __init__

> >>     raise ImportError("Could not import settings '%s' (Is it on

> >> sys.path?): %s" % (self.SETTINGS_MODULE, e))

> >> ImportError: Could not import settings 'toastermain.settings' (Is it on

> >> sys.path?): No module named tzlocal

> >>

> >> Error on migration, trying to recover...

> >>

> >> Traceback (most recent call last):

> >>   File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,

> >> in <module>

> >>     execute_from_command_line(sys.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 453, in execute_from_command_line

> >>     utility.execute()

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 392, in execute

> >>     self.fetch_command(subcommand).run_from_argv(self.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 263, in fetch_command

> >>     app_name = get_commands()[subcommand]

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 109, in get_commands

> >>     apps = settings.INSTALLED_APPS

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 52, in __getattr__

> >>     self._setup(name)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 47, in _setup

> >>     self._wrapped = Settings(settings_module)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 132, in __init__

> >>     raise ImportError("Could not import settings '%s' (Is it on

> >> sys.path?): %s" % (self.SETTINGS_MODULE, e))

> >> ImportError: Could not import settings 'toastermain.settings' (Is it on

> >> sys.path?): No module named tzlocal

> >> Traceback (most recent call last):

> >>   File "/home/yocto/poky/bitbake/bin/../lib/toaster/manage.py", line 10,

> >> in <module>

> >>     execute_from_command_line(sys.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 453, in execute_from_command_line

> >>     utility.execute()

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 392, in execute

> >>     self.fetch_command(subcommand).run_from_argv(self.argv)

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 263, in fetch_command

> >>     app_name = get_commands()[subcommand]

> >>   File

> >> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py",

> >> line 109, in get_commands

> >>     apps = settings.INSTALLED_APPS

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 52, in __getattr__

> >>     self._setup(name)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 47, in _setup

> >>     self._wrapped = Settings(settings_module)

> >>   File "/usr/lib/python2.7/site-packages/django/conf/__init__.py", line

> >> 132, in __init__

> >>     raise ImportError("Could not import settings '%s' (Is it on

> >> sys.path?): %s" % (self.SETTINGS_MODULE, e))

> >> ImportError: Could not import settings 'toastermain.settings' (Is it on

> >> sys.path?): No module named tzlocal

> >> Failed start.

> >>

> >>

> >> I am guessing this is related to the timezone fix, but I don't know how

> >>to

> >> work around it. Any ideas?

> >>

> >> Thanks!!

> >>

> >> Belén

> >>

> >

>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/3e99410a/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 24914 bytes
Desc: image001.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/3e99410a/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 20320 bytes
Desc: image002.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/3e99410a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.png
Type: image/png
Size: 29764 bytes
Desc: image003.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/3e99410a/attachment-0007.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image004.png
Type: image/png
Size: 9903 bytes
Desc: image004.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/3e99410a/attachment-0008.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image005.png
Type: image/png
Size: 19085 bytes
Desc: image005.png
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140307/3e99410a/attachment-0009.png>