[Toaster] toaster: review request for build dash board page

[Barros Pena, Belen]

On 06/03/2014 18:36, "Wymore, Farrell" <Farrell.Wymore at windriver.com>
wrote:

>Hi Belen,
>
>Thanks for the thorough comments.
>Questions/comments embedded.
>
>    - fw
>
>-----Original Message-----
>From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>Sent: Thursday, March 06, 2014 6:40 AM
>To: Wymore, Farrell
>Cc: toaster at yoctoproject.org
>Subject: Re: toaster: review request for build dash board page
>
>Hi Farrell,
>
>Thanks for this. I have a few comments, but I think they should be all
>easy to fix. There they go:
>
>* The breadcrumb should not have the last Dashboard item. It is
>represented by the build target + machine + completed on time stamp,
>which should be the final, not clickable element of the breadcrumb

>I'm not sure what you mean by 'breadcrumb': is this the links on the All
>Builds page? The title on the Dashboard page?

Right, sorry: the breadcrumb is the element at the top of the page that
indicates the path to the current page. It is mainly set in the
basebuildpage.html template, but then builddashboard.html is adding:

{% block localbreadcrumb %}
<li>Dashboard</li>
{% endblock %}

That is what needs to go

>
>* If a build has multiple targets, the breadcrumb should only show the
>first one (in alphabetical order). For example, I have a build that has 2
>targets: core-image-base and core-image-minimal. The breadcrumb for this
>build should say: "core-image-base (+1)" but it says "core-image-minimal
>(+1)" instead.
>Again, I'm not sure what breadcrumb means. I guess it's the links on the
>All Builds page? In any event, I can fix that too, if no one else is
>working on this.

I hope the above explains! This is probably coming from basebuildpage.html
though, not your page.

>
>* The same with the left navigation, in the Images section targets should
>be listed in ascending alphabetical order. For the same build as above, I
>have again core-image-minimal displaying above core-image-base. It should
>be the other way around.
>Ok.
>
>* The same with the order in the h1.
>Ok.
>
>* Also, the in the h1 target names should be separated by commands.
>You mean commas?

Yes, I did mean commas (damn you autocorrect!)

>
>* The build status notification should say "Completed on" or "Failed on"
>before the time stamp. It should only say 'with' if there are errors or
>warnings.
>Since you pointed this out, I realized how weird it appears.

:)

>
>* If there are errors and warnings the build status notification should
>say 'with # errors and # warnings'. Also, remove the .span2 class from
>the <span> tags that contain the number of errors and warnings. That way
>things look a bit more like a sentence.
>Ok.
>
>* The link to the build time page is not working. The URL is set to
>/build/build-time/ so it is missing the build id:
>/build/<build_id>/build-time
>I don't think build-time.html has been defined yet. Of course,  I'm happy
>to implement it, if no one else is trying to work on it.

David built that page, but sorry, it is not called built-time: it is
buildtime. So the right url is /build/<build_id>/buildtime

>
>* The image content module should only exist for those targets that are
>image recipes (things like core-image-minimal). Right now it is also
>showing for recipes (things like bash or busybox). When you have more
>than one target that is an image recipe within a build, the image modules
>should also be sorted in alphabetical order, so they match the navigation
>and the page heading.
>Ok.
>
>* The URL of the number of packages installed is not correct. It is set
>to /build/image-information-packages.html but it should be set to
>/build/<build_id>/target/<target_id>
>Do you mean 'Packages included'? I believe this html is an unimplemented
>place holder. If the url is set to /build/<build id>/target/<target id>,
>this would be the same url  for as for each image title.  Is this correct?

Yes, that's correct. Dave Lerner has that page well underway, so it should
be ready soon.

>
>* The label "License manifest² should be a link to the 'Packages included'
>tab in the corresponding '1.1 Image information' page, showing the
>following columns: Package, Package version, License and Recipe (i.e. the
>information provided by the package manifest file).
>Ok, I'm still a bit worried about where the content (anchor text) is
>coming from.
>
>* In the Configuration information, the layers should be listed in
>alphabetical order
>Ok.
>
>* In the Tasks information, instead of 'Tasks prebuilt' it should say
>'Tasks not executed'
>I'm not sure what you're referring to: is this the pop-down in the
>Outcome colume?

This is the tasks content module, the middle box under the "Build summary"
heading

>
>* In the Tasks information we are missing the Failed tasks (if there are
>any). We are also missing the links:
>
>** The number of tasks is a link to the tasks table
>** The number of executed tasks is a link to the tasks table with the
>'Executed tasks' filter applied
>** The number of not executed tasks is a link to the tasks table with the
>³Not executed tasks² filter applied
>Ok.
>
>* In the Recipes and Packages information, the recipes item should say
>'Recipes built'. We are also missing the links:
>
>** The number of recipes should be a link to the recipes table
>** The number of packages should be a link to the packages built table
>Ok.
>
>* I am not able to collapse the errors module
>Hmm... works for me.
>
>* I am not able to expand the warnings module
>Ditto - what browser are you using?

Firefox 26.0 on Fedora 18

>
>* If a build throws no warnings, the warnings module should not display
>(right now it shows with heading '0 warnings').
>Ok.
>
>If you have any questions, let me know.
>
>Cheers
>
>Belén
>
>
>
>On 05/03/2014 18:24, "Wymore, Farrell" <Farrell.Wymore at windriver.com>
>wrote:
>
>>Dear Belen,
>> 
>>I have pushed my first request for the build dash board page.
>>I have tested for multiple build targets and targets that are not
>>images.
>> 
>>I¹ve applied Alex¹s patch for the database changes and manually
>>included Amit¹s error and warning  code.
>> 
>>    fwymore/build-dashboard
>> 
>>The exceptions for this review are:
>>· Waiting for license manifest decision · Waiting for image file table
>>population from Alex · Issue around cached packages installed list We
>>plan to review these in tomorrow¹s call.
>> 
>>Thanks ­ Farrell
>> 
>>
>
>