[Toaster] Process for review requests pushed to poky/contrib?

[Paul Eggleton]

Hi David,

So FYI Alex is away today so I haven't talked to him about this yet, but our 
thinking on this is that we'll stop using toaster/master from now on, with 
people basing their work on poky master instead (note, this is *not* 
poky-contrib master; if you don't already have the poky repository set up as a 
remote you'll need to add it with "git remote add"). However, I think it's 
worth us sticking to review of Toaster changes on this mailing list with one 
person gathering the various branches together and sending them for merging 
into BitBake.

2) The way we normally work, it's up to individual developer to notice when 
the patch has merged and set the bug status accordingly; pushes upstream are 
always done by Richard and if he had to do all the bug resolutions as well he 
probably wouldn't have time for anything else ;)

So I figure the immediate next step is for Alex or myself to collect the 
reviewed patches up onto a branch and submit it for merging to BitBake.

Cheers,
Paul

On Monday 10 March 2014 18:27:56 Reyna, David wrote:
> We now have a number of review requests that have passed your review.
> 
> 1. Are you the person that will get them pushed to upstream (and/or via Paul
> and Alex)?
> 
> 2. How do we (the developer) know when each one is pushed, so that we can
> move the state to RESOLVED? I need this state to know when to let my tester
> work on the validation.
> 
> (FYI, at Wind River the person who pushes to code to the upstream repo ia
> the one who moves those cases to RESOLVED to remove ambiguity of timing).
> 
> Just trying to move quickly and correctly through the backlog.
> 
> Thanks,
> David
> 
> 
> ----- Original Message -----
> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> Sent: Monday, March 10, 2014 11:03 AM
> To: Ravi Chintakunta <ravi.chintakunta at timesys.com>;
> 'toaster at yoctoproject.org' <toaster at yoctoproject.org> Subject: Re:
> [Toaster] review request for counters for filters
> 
> On 10/03/2014 17:25, "Ravi Chintakunta" <ravi.chintakunta at timesys.com>
> 
> wrote:
> >Hi Belen,
> >
> >Thanks for the quick review. I have pushed my changes to the
> >ravi/bug-fixes branch.
> 
> Looking good for me.
> 
> Thanks!
> 
> Belén
> 
> >-Ravi
> >
> >>  -----Original Message-----
> >>  From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> >>  Sent: Monday, March 10, 2014 1:03 PM
> >>  To: Ravi Chintakunta; 'toaster at yoctoproject.org'
> >>  Subject: Re: [Toaster] review request for counters for filters
> >>  
> >>  On 10/03/2014 16:41, "Ravi Chintakunta" <ravi.chintakunta at timesys.com>
> >>  
> >>  wrote:
> >>  >I have pushed the implementation for adding counters to filters
> >>  >
> >>  >https://bugzilla.yoctoproject.org/show_bug.cgi?id=5821
> >>  >
> >>  >to my branch: ravi/bug-fixes
> >>  >
> >>  >http://git.yoctoproject.org/cgit/cgit.cgi/poky-> >>  
> >>  contrib/commit/?h=ravi/bug-
> >>  
> >>  >fixes&id=6da9e0124b2e749755714d8d8320cfd3d7884f5c
> >>  
> >>  This is pretty neat functionality :) Just 2 tiny things:
> >>  
> >>  * When the counter is 0, we are missing a space between the end of the
> >>  option name and the opening parenthesis of the counter
> >>  * When the filter is applied on top of search results, we are missing
> >>  ' '
> >>  around the search string
> >>  
> >>  >Please note that the counts for the filters in config variables is
> >>  
> >>  not
> >>  
> >>  >adding up to the total count. Looks like there are config variables
> >>  
> >>  that
> >>  
> >>  >are set in other files and that are not displayed as filter option.
> >>  
> >>  Yed, this is indeed the case. Our "set in file" filters do not cover
> >>  all
> >>  the files where variables can be set. Also, a variable might be set by
> >>  more than one file.
> >>  
> >>  Cheers
> >>  
> >>  >Thanks,
> >>  >Ravi
> >>  >
> >>  >
> >>  >--
> >>  >_______________________________________________
> >>  >toaster mailing list
> >>  >toaster at yoctoproject.org
> >>  >https://lists.yoctoproject.org/listinfo/toaster
> 
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.