[Toaster] review request for counters for filters

[Damian, Alexandru]

And taken in for the submission


On Mon, Mar 10, 2014 at 6:03 PM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

> On 10/03/2014 17:25, "Ravi Chintakunta" <ravi.chintakunta at timesys.com>
> wrote:
>
> >Hi Belen,
> >
> >Thanks for the quick review. I have pushed my changes to the
> >ravi/bug-fixes branch.
>
> Looking good for me.
>
> Thanks!
>
> Belén
>
> >
> >-Ravi
> >
> >>  -----Original Message-----
> >>  From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> >>  Sent: Monday, March 10, 2014 1:03 PM
> >>  To: Ravi Chintakunta; 'toaster at yoctoproject.org'
> >>  Subject: Re: [Toaster] review request for counters for filters
> >>
> >>  On 10/03/2014 16:41, "Ravi Chintakunta" <ravi.chintakunta at timesys.com>
> >>  wrote:
> >>
> >>  >I have pushed the implementation for adding counters to filters
> >>  >
> >>  >https://bugzilla.yoctoproject.org/show_bug.cgi?id=5821
> >>  >
> >>  >to my branch: ravi/bug-fixes
> >>  >
> >>  >http://git.yoctoproject.org/cgit/cgit.cgi/poky-
> >>  contrib/commit/?h=ravi/bug-
> >>  >fixes&id=6da9e0124b2e749755714d8d8320cfd3d7884f5c
> >>
> >>  This is pretty neat functionality :) Just 2 tiny things:
> >>
> >>  * When the counter is 0, we are missing a space between the end of the
> >>  option name and the opening parenthesis of the counter
> >>  * When the filter is applied on top of search results, we are missing
> >>  ' '
> >>  around the search string
> >>
> >>  >
> >>  >Please note that the counts for the filters in config variables is
> >>  not
> >>  >adding up to the total count. Looks like there are config variables
> >>  that
> >>  >are set in other files and that are not displayed as filter option.
> >>
> >>  Yed, this is indeed the case. Our "set in file" filters do not cover
> >>  all
> >>  the files where variables can be set. Also, a variable might be set by
> >>  more than one file.
> >>
> >>  Cheers
> >>  >
> >>  >Thanks,
> >>  >Ravi
> >>  >
> >>  >
> >>  >--
> >>  >_______________________________________________
> >>  >toaster mailing list
> >>  >toaster at yoctoproject.org
> >>  >https://lists.yoctoproject.org/listinfo/toaster
> >
>
> --
> _______________________________________________
> toaster mailing list
> toaster at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140312/5e3fb3e6/attachment.html>