[Toaster] toaster: review request for build dash board page

Damian, Alexandru alexandru.damian at intel.com
Wed Mar 12 11:25:30 PDT 2014


Let's keep it like this for now, since I want it merged, Farrell depends on
this.

Taken in.

Alex


On Wed, Mar 12, 2014 at 6:20 PM, Barros Pena, Belen <
belen.barros.pena at intel.com> wrote:

> On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit at floatingpondtech.com>
> wrote:
>
> >
> >Hi Alex, Belen,
> >
> >
> >Thanks, that¹s where I have added it, pushed the branch to
> >achaudhary/errors_warnings_ondashboard_v6.
>
> Hi Amit,
>
> This is looking good, although you don't need lines 95 and 113, since
> there is already a $(document).ready(function(){}); block in the script.
> You just need to paste the additional lines inside it.
>
> Cheers
>
> Belén
>
>
>
> >
> >
> >
> >
> >--
> >Amit Kumar Chaudhary
> >
> >
> >
> >On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
> >(alexandru.damian at intel.com) wrote:
> >
> >this is also a good solution :)
> >
> >Alex
> >
> >
> >
> >
> >On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
> ><belen.barros.pena at intel.com> wrote:
> >
> >On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit at floatingpondtech.com>
> >wrote:
> >>
> >>If not, the javascript code should be in the same file as the elements it
> >>changes.
> >
> >
> >FWIW, I have been putting all javascript code in static/js/main.js
> >
> >Cheers,
> >
> >Belén
> >
> >
> >
> >
> >
> >
> >
> >--
> >Alex Damian
> >Yocto Project
> >
> >SSG / OTC
> >
> >
> >
> >
> >
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140312/76476fac/attachment.html>


More information about the toaster mailing list