[Toaster] review request Bug #5960 "No help text next to the "Apply" button when a filter from a different column is applied to a table."

[Barros Pena, Belen]

On 14/03/2014 07:40, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belen,
> 
>Here is another review request. This is to add (in the filter pop-up
>dialog) the message ³You can only apply one filter to the table. This
>filter will override the current filter² when a different filter is
>currently applied, as per your design document
> ³Filtering the ŒAll builds¹ table² page 7.
> 
>The review branch is here:  dreyna/second_filter_5960
> 
>Notes: 
>  1. Currently the warning string is right-justified, but your design
>document has it left-justified next to the button. Is that ok? Otherwise,
>can you tell me how to adjust the CSS for "modal-footer"?

Just wrap the message into a span with the classes .pull-left and
.help-inline. 

<span class="help-inline pull-left">... </span>

Then add the following to the end of the /static/css/default.css file:

.help-inline { margin: 5px; }

That should align things nicely :)

> 
>  2. I ended up with a nested IF for the test to show the message ,
>because I could not get Django to accept the two tests in one IF.
> 
>The test is (a) if there is an existing filter string in the session, and
>(b) the existing filter has a different prefix from this dialog¹s filter
>prefix, then show the warning string.
> 
>Here is the code in ³filtersnippet.html²:
>        <div class="modal-footer">
>            <button type="submit" class="btn btn-primary">Apply</button>
>            {% if request.GET.filter %}
>                {% if request.GET.filter|string_remove_regex:':.*' !=
>f.options.0.1|string_remove_regex:':.*' %}
>                You can only apply one filter to the table. This filter
>will override the current filter.
>                {% endif %}
>            {% endif %}
>        </div>
> 
>- David
> 
>