[Toaster] V2: review request Bug #5960 "No help text next to the "Apply" button when a filter from a different column is applied to a table."

[Reyna, David]

Hi Belen,

Thanks, the updated review branch is here:  dreyna/second_filter_5960

I will disclose that I lost several hours testing this. I will summarize what I found out:

  * For FireFox 27.0.1 (with Windows 7), the “help-inline” style was strangely limited. If present it provided only an effective “margin-left: 5px” _regardless_ of any other settings, for example for margin, font, or color (those later items were from when I was getting desperate to prove that it was noticed at all). It was maddening.

  * It wasn’t until I tried Firefox 26.0 (Ubuntu ) or Safari 5.1.7 (Windows 7) - both which worked as expected, that I realized that the limitation was due to this particular Firefox.

  * I may file a low level bug later just to track this issue. This is the first time with this browser that I have seen a rendering limitation. The only observable artifact is that the text message is aligned high instead of vertically centered.

- David

p.s. I observed that IE 8.0 was totally broken for filter popups, so forget that relic.

> -----Original Message-----
> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
> Sent: Friday, March 14, 2014 6:52 AM
> To: Reyna, David; DAMIAN, ALEXANDRU
> Cc: toaster at yoctoproject.org
> Subject: Re: review request Bug #5960 "No help text next to the "Apply"
> button when a filter from a different column is applied to a table."
> 
> On 14/03/2014 07:40, "Reyna, David" <david.reyna at windriver.com> wrote:
> 
> >Hi Belen,
> >
> >Here is another review request. This is to add (in the filter pop-up
> >dialog) the message ³You can only apply one filter to the table. This
> >filter will override the current filter² when a different filter is
> >currently applied, as per your design document
> > ³Filtering the ŒAll builds¹ table² page 7.
> >
> >The review branch is here:  dreyna/second_filter_5960
> >
> >Notes:
> >  1. Currently the warning string is right-justified, but your design
> >document has it left-justified next to the button. Is that ok? Otherwise,
> >can you tell me how to adjust the CSS for "modal-footer"?
> 
> Just wrap the message into a span with the classes .pull-left and
> .help-inline.
> 
> <span class="help-inline pull-left">... </span>
> 
> Then add the following to the end of the /static/css/default.css file:
> 
> .help-inline { margin: 5px; }
> 
> That should align things nicely :)
> 
> >
> >  2. I ended up with a nested IF for the test to show the message ,
> >because I could not get Django to accept the two tests in one IF.
> >
> >The test is (a) if there is an existing filter string in the session, and
> >(b) the existing filter has a different prefix from this dialog¹s filter
> >prefix, then show the warning string.
> >
> >Here is the code in ³filtersnippet.html²:
> >        <div class="modal-footer">
> >            <button type="submit" class="btn btn-primary">Apply</button>
> >            {% if request.GET.filter %}
> >                {% if request.GET.filter|string_remove_regex:':.*' !=
> >f.options.0.1|string_remove_regex:':.*' %}
> >                You can only apply one filter to the table. This filter
> >will override the current filter.
> >                {% endif %}
> >            {% endif %}
> >        </div>
> >
> >- David
> >
> >
>