[Toaster] toaster: review request for build dash board page

[Reyna, David]

Hi Amit,

FYI, I noticed that your commit is missing the “[YOCTO # 4283]” line. You should probably make sure you include that when you post your final fix for this feature.

Thanks,
David

============================
commit d3d3a2c6ba71767e49a5b62fe74bf3b47688b911
Author: Amit Kumar Chaudhary <amit at floatingpondtech.com>
Date:   Wed Mar 12 18:47:42 2014 +0000

    bitbake: toaster: add errors and warnings listing

    Add the errors and warnings listing to the build
    dashboard page.

    (Bitbake rev: 2004c0fd1dd049d26279ee10a18e69e6852247fa)

    Signed-off-by: Amit Kumar Chaudhary <amit at floatingpondtech.com>
    Signed-off-by: Richard Purdie richard.purdie at linuxfoundation.org<mailto:richard.purdie at linuxfoundation.org>


From: Amit Kumar Chaudhary [mailto:amit at floatingpondtech.com]
Sent: Thursday, March 13, 2014 7:13 AM
To: DAMIAN, ALEXANDRU; BARROS PENA, BELEN
Cc: toaster at yoctoproject.org; Wymore, Farrell; Reyna, David
Subject: Re: [Toaster] toaster: review request for build dash board page

Hi Alex, Belen,

I will submit a patch to fix it later.

Thanks for sending it out for the merge.

—amit

On 12 March 2014 at 11:55:30 pm, Damian, Alexandru (alexandru.damian at intel.com<mailto:alexandru.damian at intel.com>) wrote:
Let's keep it like this for now, since I want it merged, Farrell depends on this.

Taken in.
Alex

On Wed, Mar 12, 2014 at 6:20 PM, Barros Pena, Belen <belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>> wrote:
On 12/03/2014 18:13, "Amit Kumar Chaudhary" <amit at floatingpondtech.com<mailto:amit at floatingpondtech.com>>
wrote:

>
>Hi Alex, Belen,
>
>
>Thanks, that¹s where I have added it, pushed the branch to
>achaudhary/errors_warnings_ondashboard_v6.
Hi Amit,

This is looking good, although you don't need lines 95 and 113, since
there is already a $(document).ready(function(){}); block in the script.
You just need to paste the additional lines inside it.

Cheers

Belén



>
>
>
>
>--
>Amit Kumar Chaudhary
>
>
>
>On 12 March 2014 at 11:33:50 pm, Damian, Alexandru
>(alexandru.damian at intel.com<mailto:alexandru.damian at intel.com>) wrote:
>
>this is also a good solution :)
>
>Alex
>
>
>
>
>On Wed, Mar 12, 2014 at 4:03 PM, Barros Pena, Belen
><belen.barros.pena at intel.com<mailto:belen.barros.pena at intel.com>> wrote:
>
>On 12/03/2014 15:10, "Amit Kumar Chaudhary" <amit at floatingpondtech.com<mailto:amit at floatingpondtech.com>>
>wrote:
>>
>>If not, the javascript code should be in the same file as the elements it
>>changes.
>
>
>FWIW, I have been putting all javascript code in static/js/main.js
>
>Cheers,
>
>Belén
>
>
>
>
>
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>
>
>
>



--
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/toaster/attachments/20140315/ec33a27c/attachment.html>