[Toaster] review request for Bug #5961 "Search and filters in the BitBake variables table do not interact like in all other pages"

Barros Pena, Belen belen.barros.pena at intel.com
Mon Mar 17 07:04:33 PDT 2014


On 15/03/2014 22:19, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belen,
> 
>In testing the fix, as a regression test I used changing pages to insure
>that the filter was not accidently reset in those circumstances. I doing
>so, I came across a behavior I was not sure you intended, and that is
>this:
> 
>    If you select a new search, not only are any filters reset to off,
>but the page count selection is also reset. It would seem to me that if a
>user explicitly selects a page count (to match their screen or
>environment and/or stress capacity), that they
> would lose that selection with every new search and be forced to re-set
>it over and over.

I had a bug opened for this, and closed it because I couldn't quite decide
on what we should keep. Right now, the cookie keeps only the state of the
Edit columns menu. I can reopen it to add the "Show rows" selection, which
I think makes sense. Filters and search I don't think we should keep, but
what about the sorting?

> 
>I just wanted to bring that question to your attention.
> 
>My commit branch is here: dreyna/reset_filter_5961

This is working for me. Thanks!

> 
>Thanks!
>David
> 
> 



More information about the toaster mailing list