[Toaster] V2: review request: Bug #4865 "We need empty states for the different pages"

[Barros Pena, Belen]

Everything done! 

But now the <div class="page-header"> is gone when the database is empty
and there are no builds running, and it looks a bit odd :/

On 18/03/2014 13:23, "Reyna, David" <david.reyna at windriver.com> wrote:

>Hi Belen,
>
>Thank you for your review. I have made and tested the changes:
>    dreyna/empty_4865
>
>> I normally send a keyboard interrupt towards the end of the recipe
>>parsing
>> process. That gets me a build with no tasks.
>
>You are more nimble fingered than I. I can now get the zero packages, but
>for the task list I keep getting at least the native-qemu task.
>
>> * In the Tasks, Time, CPU and Disk I/O pages 2 pipes are appearing above
>> the h1 "||".
>
>Sorry, a left over debugging statement, now gone from this commit.
>
>I have been trying to find a way to get the "order" field to re-appear by
>default in the All Tasks page, but Toaster is confounding me. Playing
>with the hidden flag, the default sorting, the column position, renaming
>the "clclass", none of those work :-(
>
>- David
>
>> -----Original Message-----
>> From: Barros Pena, Belen [mailto:belen.barros.pena at intel.com]
>> Sent: Tuesday, March 18, 2014 5:09 AM
>> To: Reyna, David
>> Cc: toaster at yoctoproject.org
>> Subject: Re: review request: Bug #4865 "We need empty states for the
>> different pages"
>>
>>
>>
>> On 18/03/2014 03:11, "Reyna, David" <david.reyna at windriver.com> wrote:
>>
>> >I could not figure out a proper way to get an empty task list, so I
>> >simulated it by commenting out the ³objects² value in the context for
>>the
>> >³tasks² view (as described below in my test plan).
>>
>> I normally send a keyboard interrupt towards the end of the recipe
>>parsing
>> process. That gets me a build with no tasks.
>>
>> It's pretty much there. A couple of comments below:
>>
>> ALL BUILDS PAGE
>>
>> * We should set the href of the "Show me the manual" button to the right
>> URL (https://www.yoctoproject.org/documentation/toaster- manual) even if
>> the page doesn't exist yet. That way is already done and it's something
>> less to think about when the release time pressure kicks :)
>>
>> * When the first build is running (no builds completed yet in the
>> database) the All builds section should not display
>>
>> * The spacing in the hero unit is a bit crammed. Can we add the
>>following
>> lines to default.css?
>>
>> .hero-unit { margin: 20px 0 30px; }
>> .hero-unit > .close { font-size:40px; }
>> .hero-actions { margin-top: 30px; }
>>
>> That will sort out the problem
>>
>> BUILT PACKAGES TABLE
>>
>> * Can we change "No Packages built" to "No packages built"?
>>
>> * Instead of "slight" the alert should say "slightly"
>>
>> GENERIC EMPTY STATE (tested with Tasks)
>>
>> * Time, CPU and Disk I/O pages are showing "Tasks" as h1
>>
>> * In the Tasks, Time, CPU and Disk I/O pages 2 pipes are appearing above
>> the h1 "||".
>>
>>
>>
>